Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsumptive clauses crash when dominated and dominating heads are identical. #2240

Merged
merged 5 commits into from
Mar 30, 2022

Conversation

b-scholz
Copy link
Member

This PR fixes issues #2227 and #2228.

@b-scholz b-scholz changed the title Souffle crashes for specific subsumption clauses Subsumptive clauses crash when dominated and dominating heads are identical. Mar 30, 2022
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #2240 (a674fb6) into master (d98a78a) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2240      +/-   ##
==========================================
- Coverage   75.83%   75.80%   -0.03%     
==========================================
  Files         454      454              
  Lines       27588    27592       +4     
==========================================
- Hits        20920    20917       -3     
- Misses       6668     6675       +7     
Impacted Files Coverage Δ
src/ast/transform/MinimiseProgram.cpp 100.00% <100.00%> (ø)
src/ram/utility/Utils.h 100.00% <100.00%> (ø)
src/include/souffle/datastructure/LambdaBTree.h 73.28% <0.00%> (-2.30%) ⬇️
src/include/souffle/datastructure/UnionFind.h 95.60% <0.00%> (-2.20%) ⬇️
...ouffle/datastructure/ConcurrentInsertOnlyHashMap.h 82.11% <0.00%> (-1.63%) ⬇️
src/include/souffle/utility/ParallelUtil.h 83.72% <0.00%> (-1.56%) ⬇️
src/include/souffle/datastructure/BTree.h 97.05% <0.00%> (-0.43%) ⬇️
src/include/souffle/datastructure/BTreeDelete.h 57.43% <0.00%> (+0.29%) ⬆️
src/ram/utility/Visitor.h 54.61% <0.00%> (+1.53%) ⬆️

@davidwzhao davidwzhao merged commit 6806208 into souffle-lang:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants