Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type system when a record's field is an alias type #2219

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

quentin
Copy link
Member

@quentin quentin commented Mar 16, 2022

Fix the type system when a record's field is an alias type.
Added a test.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #2219 (604e2aa) into master (f16d18d) will decrease coverage by 0.26%.
The diff coverage is 67.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2219      +/-   ##
==========================================
- Coverage   75.52%   75.25%   -0.27%     
==========================================
  Files         452      454       +2     
  Lines       27479    27572      +93     
==========================================
- Hits        20753    20749       -4     
- Misses       6726     6823      +97     
Impacted Files Coverage Δ
src/RelationTag.h 52.23% <0.00%> (-0.80%) ⬇️
src/ast/ExecutionOrder.h 100.00% <ø> (ø)
src/ast/Program.h 100.00% <ø> (ø)
src/ast/transform/ComponentInstantiation.cpp 92.36% <ø> (+0.38%) ⬆️
src/ast/transform/MinimiseProgram.h 100.00% <ø> (ø)
src/ast/transform/ResolveAliases.cpp 98.93% <ø> (ø)
src/ast/utility/SipsMetric.h 18.18% <ø> (ø)
src/ast/utility/Utils.h 100.00% <ø> (ø)
src/ast/utility/Visitor.h 57.33% <0.00%> (ø)
src/ast2ram/provenance/ClauseTranslator.h 100.00% <ø> (ø)
... and 133 more

Copy link
Member

@b-scholz b-scholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@b-scholz b-scholz merged commit 2ba5996 into souffle-lang:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants