Swallow "remote not found" error on git before 2.30 #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git 2.30.0 introduced a dedicated exit code (2) for when `git remote rm` failed because the remote does not exist. Earlier versions of git always returned code 128, and only parsing stderr could tell the error conditions apart. Support all versions of git by checking for both exit code 2, and exit code 128 with the specific error message. The exit code 2 check remains more robust against localized output, hence it's kept in addition to the output parsing path that was removed in sorenlouv#505. Fixes sorenlouv#509
sorenlouv
force-pushed
the
delete-remote-git-before-2.30
branch
from
4d68b93
to
766625b
Compare
|
Published in v9.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git 2.30.0 introduced a dedicated exit code (2) for when
git remote rmfailed because the remote does not exist. Earlier versions of git
always returned code 128, and only parsing stderr could tell the error
conditions apart.
Support all versions of git by checking for both exit code 2, and exit
code 128 with the specific error message. The exit code 2 check remains
more robust against localized output, hence it's kept in addition to the
output parsing path that was removed in #505.
Fixes #509