set BytecodeBodyInterceptors as default for BytecodeFrontend based InputLocations #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissiety
force-pushed
the
remove/ClassloadingOps
branch
from
3953913
to
78bae3c
Compare
swissiety
changed the title
swissiety
force-pushed
the
remove/ClassloadingOps
branch
from
78bae3c
to
a7762ee
Compare
…stom selection of BodyInterceptors
swissiety
force-pushed
the
remove/ClassloadingOps
branch
from
a7762ee
to
b2939be
Compare
…r JavaClassPathAnalysisInputLocation
swissiety
changed the title
swissiety
changed the title
|
--> the pipeline runs on a merged branch of targetBranch + currentBranch |
swissiety
changed the title
…ecessor if a removed block has more instances of the removed block as a predecessor than the successor has the removed block as predecessor
… successorIdx is now known
…ead to problem of trying to (prepare) replacing an not existing Stmt(just an equivalent one)
…l needed when aggregating failed
JonasKlauke
reviewed
Feb 19, 2024
sootup.core/src/main/java/sootup/core/jimple/common/stmt/AbstractStmt.java
Show resolved
Hide resolved
sootup.core/src/main/java/sootup/core/jimple/visitor/ReplaceUseStmtVisitor.java
Show resolved
Hide resolved
sootup.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/Aggregator.java
Show resolved
Hide resolved
...p.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/ConditionalBranchFolder.java
Show resolved
Hide resolved
...tecode/src/test/java/sootup/java/bytecode/minimaltestsuite/MinimalBytecodeTestSuiteBase.java
Show resolved
Hide resolved
|
Did this change the public api? If not should we release a 1.2.1 with this |
it should not break from the API from a compilation side -( it was basically an extension/overloading of constructors + fixing stuff in this journey) - but the intention of applying interceptors by default now should be a new minor++ release |
# Conflicts: # sootup.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/CastAndReturnInliner.java # sootup.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/ConstantPropagatorAndFolder.java # sootup.java.bytecode/src/main/java/sootup/java/bytecode/interceptors/CopyPropagator.java
JonasKlauke
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the Interceptor that does not update the Set of Locals when it removes Stmts that eliminate Local defs&usages (The TypeAssigner has Locals that do not existDeadassignmentEliminator: remove Locals, too (investigate TypeAssigner did weird with that wrong info and failed!)tried to extract these to keep the changed files smaller.. unfortunately lead to more errors that are already fixed here.
used regex: (?<!@category(Java[8|9]Test.class))(\spublic\sclass\s(\S*)[T|t]est) scope: test files