Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate dex2jar to Maven Central #768

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

ThexXTURBOXx
Copy link
Contributor

This should resolve issues with jitpack.io by making it pretty much obsolete.
Releases are done automatically - the patch version is increased automatically and corresponds to the build number in dex2jar's pipeline.

If you need anything else, feel free to contact or ping me or just open an issue at my repository!

Fixes #669

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f44580) 63.55% compared to head (53df8cf) 63.61%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #768      +/-   ##
=============================================
+ Coverage      63.55%   63.61%   +0.05%     
- Complexity      3347     3350       +3     
=============================================
  Files            318      318              
  Lines          15088    15088              
  Branches        2543     2543              
=============================================
+ Hits            9589     9598       +9     
+ Misses          4602     4593       -9     
  Partials         897      897              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JonasKlauke JonasKlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JonasKlauke JonasKlauke merged commit 382afca into soot-oss:develop Dec 6, 2023
8 checks passed
@oxisto
Copy link

oxisto commented Dec 30, 2023

I ended up here following a string of errors and issues because of the missing dex dependency. Unfortunately, there is not yet a release on mvn central of sootup that contains this fix here. Do you foresee a release with this fix any time soon?

@swissiety
Copy link
Collaborator

yes there will be a release in the near future - in the meantime you could use the latest develop via jitpack.io see https://soot-oss.github.io/SootUp/develop/installation/

@oxisto
Copy link

oxisto commented Dec 30, 2023

yes there will be a release in the near future - in the meantime you could use the latest develop via jitpack.io see https://soot-oss.github.io/SootUp/develop/installation/

Thanks. I‘ll try that as a temporary workaround. The issue is that I am trying to integrate SootUp into https://github.com/Fraunhofer-AISEC/cpg and we don’t want to force our users to use an additional repo besides Maven central. (We already need to do it for our C++ parsers, but that’s another story).

This should at least unblock development and I probably need to wait for your next release before we merge it into our main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d2j-base-cmd and d2j-jasminMissing POM preventing build
4 participants