Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cached values i.e. for the typehierarchy #658

Merged
merged 11 commits into from
Aug 1, 2023

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Jul 26, 2023

  • classtypecache
  • cached typehierarchy
    -- a wild identifierfactory occurence
  • readability

@swissiety swissiety added the improvement improve in readability, structure or performance label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 55.10% and project coverage change: -0.08% ⚠️

Comparison is base (16b693c) 64.49% compared to head (596ea94) 64.42%.
Report is 32 commits behind head on develop.

❗ Current head 596ea94 differs from pull request most recent head 4e10853. Consider uploading reports for the commit 4e10853 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #658      +/-   ##
=============================================
- Coverage      64.49%   64.42%   -0.08%     
- Complexity      3309     3311       +2     
=============================================
  Files            311      311              
  Lines          14754    14781      +27     
  Branches        2451     2484      +33     
=============================================
+ Hits            9516     9523       +7     
- Misses          4354     4363       +9     
- Partials         884      895      +11     
Files Changed Coverage Δ
.../java/sootup/core/typehierarchy/TypeHierarchy.java 79.03% <ø> (ø)
...a/sootup/core/typehierarchy/ViewTypeHierarchy.java 65.72% <0.00%> (-3.76%) ⬇️
...tup.core/src/main/java/sootup/core/types/Type.java 8.00% <ø> (ø)
...erceptors/typeresolving/types/AugIntegerTypes.java 78.94% <0.00%> (ø)
.../sootup/java/core/JavaModuleIdentifierFactory.java 98.14% <ø> (ø)
...tecode/interceptors/typeresolving/TypeChecker.java 43.67% <14.28%> (-0.33%) ⬇️
...de/interceptors/typeresolving/AugEvalFunction.java 58.91% <45.09%> (+2.46%) ⬆️
...ecode/interceptors/typeresolving/TypeResolver.java 73.98% <50.00%> (ø)
...interceptors/typeresolving/PrimitiveHierarchy.java 59.74% <51.61%> (-9.91%) ⬇️
.../interceptors/typeresolving/BytecodeHierarchy.java 81.29% <72.41%> (+1.01%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasKlauke JonasKlauke merged commit 7228de5 into develop Aug 1, 2023
6 checks passed
@JonasKlauke JonasKlauke deleted the improve/performance_TypeAssigner branch August 1, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improve in readability, structure or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants