Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/unify identifier factory references #648

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

swissiety
Copy link
Collaborator

Project stored the IdentifierFactory reference via Language field and as a dedicated field.
Now only the Language is used to store it.

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 63.15% and project coverage change: +0.01% 🎉

Comparison is base (889b9dd) 64.51% compared to head (5c67251) 64.53%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #648      +/-   ##
=============================================
+ Coverage      64.51%   64.53%   +0.01%     
  Complexity      3310     3310              
=============================================
  Files            311      311              
  Lines          14754    14736      -18     
  Branches        2451     2450       -1     
=============================================
- Hits            9519     9510       -9     
+ Misses          4352     4342      -10     
- Partials         883      884       +1     
Files Changed Coverage Δ
...ootup.core/src/main/java/sootup/core/Language.java 50.00% <0.00%> (-50.00%) ⬇️
.../java/sootup/core/jimple/common/expr/JNegExpr.java 34.61% <0.00%> (ø)
.../src/main/java/sootup/core/views/AbstractView.java 50.00% <ø> (+4.54%) ⬆️
...n/java/sootup/java/core/language/JavaLanguage.java 88.88% <ø> (+11.11%) ⬆️
.../main/java/sootup/jimple/parser/JimpleProject.java 23.52% <0.00%> (+3.52%) ⬆️
...tup.core/src/main/java/sootup/core/views/View.java 66.66% <50.00%> (+44.44%) ⬆️
...sootup/java/bytecode/frontend/AsmMethodSource.java 71.40% <90.00%> (-0.05%) ⬇️
sootup.core/src/main/java/sootup/core/Project.java 81.25% <100.00%> (-2.97%) ⬇️
...a/bytecode/interceptors/EmptySwitchEliminator.java 88.88% <100.00%> (-1.12%) ⬇️
...re/src/main/java/sootup/java/core/JavaProject.java 64.86% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JonasKlauke JonasKlauke merged commit 238c499 into develop Aug 1, 2023
7 of 8 checks passed
@JonasKlauke JonasKlauke deleted the improve/unifyIdentifierFactoryReferences branch August 1, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants