Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor weird naming PackageName.getPackageName() #646

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

swissiety
Copy link
Collaborator

to getName() which is basically the same as toString() but with getPackageName i would expect the Type again.. which would be weird.

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: -0.03 ⚠️

Comparison is base (889b9dd) 64.51% compared to head (08a21a0) 64.49%.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #646      +/-   ##
=============================================
- Coverage      64.51%   64.49%   -0.03%     
+ Complexity      3310     3309       -1     
=============================================
  Files            311      311              
  Lines          14754    14754              
  Branches        2451     2451              
=============================================
- Hits            9519     9516       -3     
- Misses          4352     4354       +2     
- Partials         883      884       +1     
Impacted Files Coverage Δ
...sootup/java/core/signatures/ModulePackageName.java 81.81% <50.00%> (ø)
...java/sootup/jimple/parser/JimpleConverterUtil.java 68.54% <50.00%> (ø)
.../main/java/sootup/core/signatures/PackageName.java 78.57% <100.00%> (-6.05%) ⬇️
...utlocation/JrtFileSystemAnalysisInputLocation.java 66.66% <100.00%> (-0.38%) ⬇️
...n/java/sootup/java/core/JavaIdentifierFactory.java 82.90% <100.00%> (ø)
...ain/java/sootup/java/core/types/JavaClassType.java 97.29% <100.00%> (ø)
...in/java/sootup/java/core/views/JavaModuleView.java 79.58% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stschott stschott merged commit 16b693c into develop Jul 18, 2023
8 checks passed
@stschott stschott deleted the deprecate/getPackageName branch July 18, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants