Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fully Qualified Name Resolving for ClassTypes #682

Closed
1 task done
JonasKlauke opened this issue Sep 8, 2023 · 3 comments · Fixed by #738
Closed
1 task done

Improve Fully Qualified Name Resolving for ClassTypes #682

JonasKlauke opened this issue Sep 8, 2023 · 3 comments · Fixed by #738

Comments

@JonasKlauke
Copy link
Collaborator

JonasKlauke commented Sep 8, 2023

  • support multi-release jars which have classes in META-INF
  • extract the fully qualified name instead of using the path chicken/egg problem
@swissiety
Copy link
Collaborator

swissiety commented Sep 15, 2023

i.e. fix AnalysisInputLocations:

  • move IdentifierFactory.fromPath() into respective PathBased....Location
  • have a fromPath() overload in MultiRelease...Location which removes the META-INF folder from name generation
  • add a check to compare the given ClassType and the parsed ClassType in the ByteCodeFrontend

@swissiety swissiety mentioned this issue Nov 2, 2023
6 tasks
@JonasKlauke
Copy link
Collaborator Author

JonasKlauke commented Nov 21, 2023

this issue is kind of connected with #713

@JonasKlauke
Copy link
Collaborator Author

path preambles can probably be created by checking every .jar file in a jar and saving that as preamble and we can define some preambles from popular frameworks like spring boot.

So we dont need more specialized inputlocations

swissiety added a commit that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants