Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to allow custom umask usage while executing plugins #42

Conversation

rajendra-dendukuri
Copy link
Collaborator

  • Use default umask value of 022 to execute ztp plugins

  • User can provide a custom umask octal value string as part of plugin data if a specific umask is required. { "plugin" : { "url" : "http://10.1.1.1/plugins/my-plugin", "umask" : "177" } }

  • Firmware plugin has been modified to always use 022 umask when installing sonic image

  • Added unit test cases to test user specified umask value

 - Use default umask value of 022 to execute ztp plugins

 - User can provide a custom umask octal value string as part of plugin data
   if a specific umask is required.
    {
      "plugin" : {
        "url" : "http://10.1.1.1/plugins/my-plugin",
        "umask" : "177"
      }
    }

 - Firmware plugin has been modified to always use 022 umask when installing
   sonic image

 - Added unit test cases to test user specified umask value
@arlakshm
Copy link

@dgsudharsan, can you please help review this PR

@arlakshm
Copy link

@qiluo-msft, @isabelmsft for viz...

@zhangyanzhao
Copy link

@adyeung can you please find someone from BRCM to review this PR?

@qiluo-msft qiluo-msft merged commit 56cebae into sonic-net:master Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants