Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proactively rekey #36

Merged
merged 3 commits into from
Sep 3, 2021
Merged

Conversation

Pterosaur
Copy link
Collaborator

@Pterosaur Pterosaur commented Aug 16, 2021

Add a new configuration instruction macsec_rekey_period to indicate the period of proactively refresh SAK.
e.g. macsec_rekey_period=1800, which means the macsec SA will be refreshed proactively every 1800 seconds.

Signed-off-by: Ze Gan ganze718@gmail.com

Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur Pterosaur marked this pull request as ready for review August 19, 2021 15:34
@@ -222,6 +222,8 @@ struct ieee802_1x_kay {
u8 dist_an;
time_t dist_time;

int macsec_rekey_period;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to call this mka_rekey_period. It's not really a macsec attribute, since it is not used by macsec driver.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense ~ Renamed it.

Signed-off-by: Ze Gan <ganze718@gmail.com>
Copy link
Contributor

@qbdwlr qbdwlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Pterosaur Pterosaur merged commit 986a835 into sonic-net:master Sep 3, 2021
Pterosaur added a commit to sonic-net/sonic-buildimage that referenced this pull request Oct 25, 2021
Signed-off-by: Ze Gan <ganze718@gmail.com>

986a835153b3df3a37492fbd3a83fc8e38a40c10 Proactively rekey sonic-net/sonic-wpa-supplicant#36
b84dd21ac7b76686caf53f2e9a2c8eb80519ab31 Fix azurepieline download sonic swss common deb pakcage sonic-net/sonic-wpa-supplicant#37
66002de9d5e3165ccdbed40451db86ae0a8b3944 [macsec_sonic] driver support for macsec_include_sci sonic-net/sonic-wpa-supplicant#35
dae8f59cb54c90bc9011bd675806a75dd0808d27 MACsec XPN changes sonic-net/sonic-wpa-supplicant#34
c2271b2879ed157718edb51e842a3e33debeab7f Move SSCI from SC to SA and change packet number field name to adapt sai 1.7.1 sonic-net/sonic-wpa-supplicant#26
1bbc8f1ef463dd21428ce80b72da107f3bd2f3f0 Fix for CP state machine issues sonic-net/sonic-wpa-supplicant#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants