Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches #990

Closed
wants to merge 2 commits into from

Conversation

stephenxs
Copy link
Collaborator

- What I did

  1. reorganize the code in a graceful and easy-to-maintain way
  2. Support migrating database regarding buffer configuration for all Mellanox switches

Depends on #970

Signed-off-by: Stephen Sun stephens@mellanox.com

- How I did it

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@prsunny
Copy link
Contributor

prsunny commented Jul 16, 2020

Based on discussion, summarizing the notes:

  1. Suggest to move the buffer configs to a different file, for maintainability of db_migrator script (Depends on the final changes based on below items)
  2. Proposal to reduce the scope of migration and change only those values that SDK cares about.
  3. Proposal to remove single pool related changes (2 pool -> 1 pool) as it doesn't break the SDK. This need not be part of migration script. This can be done post-upgrade, it will be executed step-by-step and can be provided by Mlnx

Stephen Sun added 2 commits July 17, 2020 02:11
db_migrator supports migrating old configuration who has 2 ingress pools into the new configuration who has 1 ingress pool, including BUFFER_POOL, BUFFER_PROFILE and BUFFER_PORT_INGRESS_PROFILE_LIST

Signed-off-by: Stephen Sun <stephens@mellanox.com>
1. Don't need to migrate for single buffer pool mode
2. Move buffer setting migration to another file
3. Remove unnecessary code/upgrading flows

Signed-off-by: Stephen Sun <stephens@mellanox.com>
@stephenxs
Copy link
Collaborator Author

Close it for now. Will reopen when it's ready.

@stephenxs stephenxs closed this Jul 17, 2020
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
Commits:

02dea43 [202012] Add support for BFD notification (sonic-net#990)
337fd97 Change sonic-buildimage.vs artifact source from CI build to official build. (sonic-net#992)
490f442 Support for cisco-8000 platform for sonic-sairedis/syncd (sonic-net#823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants