[sonic_installer] Refactor sonic_installer code #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this enhancement, Samuel! Would you mind pulling the new classes (Bootloader, AbootBootloader, GrubBootloader, UbootBootloader) out into their own sepearate files? This will help make main.py more readable/managable and keep the different bootloader logic isolated. |
|
Will do! Do you have a preference for the location of these files? I'm thinking of Alternatively Let me know what you think. |
|
@Staphylo: I prefer the bootloader/ subdirectory in the latter, but I believe the base Bootloader class definition should not live in the init.py file, but rather a separate file, like bootloader/bootloader.py or bootloader/bootloader_base.py because the primary purpose of the init.py file is to initialize the package, not to hold content. Thanks! |
Staphylo
force-pushed
the
master-sonic-installer-refactor
branch
2 times, most recently
from
42d2882
to
5c831c3
Compare
qiluo-msft
reviewed
Jun 20, 2020
qiluo-msft
reviewed
Jun 20, 2020
qiluo-msft
reviewed
Jun 20, 2020
jleveque
reviewed
Jun 20, 2020
qiluo-msft
reviewed
Jun 20, 2020
qiluo-msft
reviewed
Jun 20, 2020
Staphylo
force-pushed
the
master-sonic-installer-refactor
branch
3 times, most recently
from
13a6b14
to
1f0429f
Compare
jleveque
previously approved these changes
Jun 23, 2020
|
Retest this please |
Add a new Bootloader abstraction. This makes it easier to add bootloader specific behavior while keeping the main logic identical. It is also a step that will ease the introduction of secureboot which relies on bootloader specific behaviors. Shuffle code around to get rid of the hacky if/else all over the place. There are now 3 bootloader classes - AbootBootloader - GrubBootloader - UbootBootloader There was almost no logic change in any of the implementations. Only the AbootBootloader saw some small improvements. More will follow in subsequent changes.
Staphylo
force-pushed
the
master-sonic-installer-refactor
branch
from
1f0429f
to
16b5195
Compare
jleveque
approved these changes
Jun 26, 2020
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
Add a new Bootloader abstraction. This makes it easier to add bootloader specific behavior while keeping the main logic identical. It is also a step that will ease the introduction of secureboot which relies on bootloader specific behaviors. Shuffle code around to get rid of the hacky if/else all over the place. There are now 3 bootloader classes - AbootBootloader - GrubBootloader - UbootBootloader There was almost no logic change in any of the implementations. Only the AbootBootloader saw some small improvements. More will follow in subsequent changes.
lguohan
pushed a commit
that referenced
this pull request
Aug 21, 2020
The import re line was removed from the file in #953. However, it is still referenced in the update_sonic_environment() function. Adding it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Bootloader abstraction.
This makes it easier to add bootloader specific behavior while keeping
the main logic identical.
It is also a step that will ease the introduction of secureboot which
relies on bootloader specific behaviors.
Shuffle code around to get rid of the hacky if/else all over the place.
There are now 3 bootloader classes
There was almost no logic change in any of the implementations.
Only the AbootBootloader saw some small improvements.
More will follow in subsequent changes.