Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis] Modify the show ip route to hide the Ethernet-IB port in the output #3537

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Sep 8, 2024

What I did

Modify the show ip route to hide the Ethernet-IB port in the output

How I did it

  • Ignore the route nexthop entry which has Ethernet-IBx as interface name
  • update the output to indicate the route is learnt through iBGP

How to verify it

Verify on voq chassis and UT

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
@BYGX-wcr
Copy link
Contributor

BYGX-wcr commented Sep 8, 2024

The code changes look fine to me but the unit-test coverage metrics is not met.

Copy link
Contributor

@BYGX-wcr BYGX-wcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BYGX-wcr BYGX-wcr merged commit 5eb266a into sonic-net:master Sep 9, 2024
7 checks passed
@BYGX-wcr BYGX-wcr added the included in chassis for 202205 branch indicate that this PR got merged into the "chassis for 202205 branch" label Sep 12, 2024
@bingwang-ms
Copy link
Contributor

@gechiang Is this change required for 202405 branch?

@gechiang
Copy link
Contributor

@gechiang Is this change required for 202405 branch?

Yes. this is needed.
Thanks!

mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Sep 20, 2024
…e output (sonic-net#3537)

* update show ip route for voq chassis

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

* add UT

* add more UT

* Fix linter errors

* fix UT

* make linter happy

---------

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3553

mssonicbld pushed a commit that referenced this pull request Sep 21, 2024
…e output (#3537)

* update show ip route for voq chassis

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>

* add UT

* add more UT

* Fix linter errors

* fix UT

* make linter happy

---------

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants