-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chassis] Modify the show ip route to hide the Ethernet-IB port in the output #3537
Merged
BYGX-wcr
merged 6 commits into
sonic-net:master
from
arlakshm:arlakshm/master/chassis_route
Sep 9, 2024
Merged
[chassis] Modify the show ip route to hide the Ethernet-IB port in the output #3537
BYGX-wcr
merged 6 commits into
sonic-net:master
from
arlakshm:arlakshm/master/chassis_route
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
The code changes look fine to me but the unit-test coverage metrics is not met. |
BYGX-wcr
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
BYGX-wcr
added
the
included in chassis for 202205 branch
indicate that this PR got merged into the "chassis for 202205 branch"
label
Sep 12, 2024
@gechiang Is this change required for 202405 branch? |
Yes. this is needed. |
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Sep 20, 2024
…e output (sonic-net#3537) * update show ip route for voq chassis Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> * add UT * add more UT * Fix linter errors * fix UT * make linter happy --------- Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Cherry-pick PR to 202405: #3553 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 21, 2024
…e output (#3537) * update show ip route for voq chassis Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com> * add UT * add more UT * Fix linter errors * fix UT * make linter happy --------- Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved for 202405 Branch
Chassis for 202205 Branch
included in chassis for 202205 branch
indicate that this PR got merged into the "chassis for 202205 branch"
Included in 202405 Branch
Request for 202405 Branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Modify the show ip route to hide the Ethernet-IB port in the output
How I did it
Ethernet-IBx
as interface nameHow to verify it
Verify on voq chassis and UT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)