Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLIs to support TWAMP Light #3011

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

guxianghong
Copy link

What I did

Add CLIs support TWAMP Light feature according to HLD sonic-net/SONiC#1320

How I did it

  • Add config command to config twamp-light
  • Add show command to show twamp-light session

How to verify it

Manual test.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo config twamp-light session-sender packet-count add snd_1 36.1.1.1 36.1.1.2 1000 10 10 11000
admin@sonic:~$ sudo config twamp-light session-sender continuous add snd_1 22.1.1.1 22.1.1.2 60 100 10 20000
admin@sonic:~$ sudo config twamp-light session-reflector add ref_1 22.1.1.1 22.1.1.2
admin@sonic:~$
admin@sonic:~$ show twamp-light session
Time unit: Monitor Time/Timeout in second; Tx Interval/Stats Interval in millisecond
TWAMP-Light Sender Sessions
Name     Status    Sender IP:PORT    Reflector IP:PORT    Packet Count    Monitor Time      Tx Interval    Stats Interval    Timeout
-------  --------  ----------------  -------------------  --------------  --------------  -------------  ----------------  ---------
snd_1    inactive  36.1.1.1:862      36.1.1.2:863         1000            -                          10             11000         10
snd_2    inactive  22.1.1.1:862      22.1.1.2:863         -               60                        100             20000         10

TWAMP-Light Reflector Sessions
Name    Status    Sender IP:PORT    Reflector IP:PORT
------  --------  ----------------  -------------------
ref_1   active    22.1.1.1:862      22.1.1.2:863
admin@sonic:~$
admin@sonic:~$ sudo config twamp-light session-sender start all
admin@sonic:~$
admin@sonic:~$ show twamp-light statistics twoway-loss
Latest two-way loss statistics:
Name       Index    Loss Count    Loss Ratio
-------  -------  ------------  ------------
snd_1          1             0             0
               2             0             0
               3             0             0
               4             0             0
               5             0             0
               6             0             0
               7             0             0
               8             0             0
               9             0             0
              10             0             0
snd_2          1             0             0
               2             0             0
               3             0             0

Total two-way loss statistics:
Name       Loss Count(AVG)    Loss Count(MIN)    Loss Count(MAX)    Loss Ratio(AVG)    Loss Ratio(MIN)    Loss Ratio(MAX)
-------  -----------------  -----------------  -----------------  -----------------  -----------------  -----------------
snd_1                    0                  0                  0                  0                  0                  0
snd_2                    0                  0                  0                  0                  0                  0
admin@sonic:~$
admin@sonic:~$ show twamp-light statistics twoway-delay
Latest two-way delay statistics(nsec):
Name       Index    Delay(AVG)    Jitter(AVG)
-------  -------  ------------  -------------
snd_1          1          1761              0
               2          1758              0
               3          1761              0
               4          1761              0
               5          1761              0
               6          1758              0
               7          1759              0
               8          1758              0
               9          1759              0
              10          1760              0
snd_2          1          3983              1
               2          3984              1
               3          3987              1

Total two-way delay statistics(nsec):
Name       Delay(AVG)    Delay(MIN)    Delay(MAX)    Jitter(AVG)    Jitter(MIN)    Jitter(MAX)
-------  ------------  ------------  ------------  -------------  -------------  -------------
snd_1            1759          1691          1825              0              0              3
snd_2            3985          3896          4097              0              0              5
admin@sonic:~$

@guxianghong guxianghong marked this pull request as draft October 12, 2023 11:37
@guxianghong guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch from 65f699c to 9b4dc9f Compare October 19, 2023 07:33
@guxianghong guxianghong marked this pull request as ready for review October 19, 2023 07:52
@guxianghong
Copy link
Author

@qiluo-msft @yxieca @StormLiangMS @prsunny could you please help to review this PR? Thanks.
This feature is tracked for 202311 release and the HLD link is : sonic-net/SONiC#1320
@zhangyanzhao

@AlanYoush
Copy link

Hi @maipbui, TWAMP Light is for SONiC 202405 Release and sonic-net/SONiC#1320 other submodules is already merged into master.
Please help to review and approve it or assign someone on behalf of you.
Thank you very much.

@AlanYoush
Copy link

@qiluo-msft Please help to review this MR and approve to merge it.
It is important for TWAMP Light release in SONiC 202405.
Thanks very much.

@guxianghong
Copy link
Author

This PR is the last one to be merged in the TWAMP light Phase1 release, could you please help to review and merge this PR, @qiluo-msft @yxieca @StormLiangMS @prsunny @prgeor, Thanks very much.

Repo PR title State
sonic-swss TWAMP Light orchagent implementation GitHub issue/pull request detail
sonic-swss-common Added TWAMP Light table to schema GitHub issue/pull request detail
sonic-sairedis Support TWAMP Light notification in syncd GitHub issue/pull request detail
sonic-utilities Added CLIs to support TWAMP Light GitHub issue/pull request detail
SAI Added TWAMP Light API GitHub issue/pull request detail

@zhangyanzhao
Copy link
Collaborator

@qiluo-msft @oleksandrivantsiv can you please help to review and merge this PR if you are ok? This is the last open code PR for this feature? Thanks.

@zhangyanzhao
Copy link
Collaborator

waiting for reviewer's update.

@liat-grozovik liat-grozovik requested review from a team and removed request for qiluo-msft and oleksandrivantsiv May 15, 2024 16:20
@liat-grozovik
Copy link
Collaborator

@sonic-utilities-maintainer could you please help to review?

@guxianghong
Copy link
Author

@sonic-utilities-maintainer could you please help to review?

Thank you for sending the review & merge request.
Please help to review & merge this PR, @qiluo-msft @oleksandrivantsiv @zhangyanzhao . Thanks very much.

@zhangyanzhao zhangyanzhao requested review from qiluo-msft and eddieruan-alibaba and removed request for a team and qiluo-msft May 22, 2024 16:37
@zhangyanzhao
Copy link
Collaborator

Alibaba is the registered reviewer. @eddieruan-alibaba can you please find someone from Alibaba to review this PR? Thanks.

@guxianghong
Copy link
Author

@eddieruan-alibaba @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @prgeor @clarklee-guizhao Please help to review & merge this PR . Thanks very much.

@zhangyanzhao
Copy link
Collaborator

@eddieruan-alibaba can you please help to review this PR? Thanks.

@eddieruan-alibaba
Copy link

I have asked Shuanghong from my team to review it. We are using software twamp

@guxianghong
Copy link
Author

I have asked Shuanghong from my team to review it. We are using software twamp

Thank you very much for reviewing. The TWAMP light HLD has considered both software and hardware-based TWAMP light solutions, and the implementation in SONiC utility here is unified. We will contribute the software implementation to the community later, and hope your team can help review it at that time, Thanks.

@guxianghong guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch 2 times, most recently from a560c83 to 5e4ceae Compare August 3, 2024 10:56
@guxianghong
Copy link
Author

Thank you for reviewing and approving this PR, @goomadao.
Would you please help to merge this PR, @eddieruan-alibaba @qiluo-msft @oleksandrivantsiv @zhangyanzhao Thanks a lot.

@guxianghong
Copy link
Author

Please help to merge this PR, @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao Thanks a lot

@guxianghong
Copy link
Author

All pipelines have been passed and goomadao have been finied his review, please help to merge this PR, @liat-grozovik @abdosi @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao Thanks very much.

@eddieruan-alibaba
Copy link

eddieruan-alibaba commented Sep 6, 2024

This PR has already reviewed and approved by Shuanghong from Alibaba team. Now it needs a repro reviewer's approval.

@guxianghong
Copy link
Author

All pipelines have been passed and Eddie confirmed that Shuanghong from Alibaba team has already reviewed and approved. Please help to merge this PR, @liat-grozovik @abdosi @qiluo-msft @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao, Thanks very much.

@qiluo-msft
Copy link
Contributor

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

@guxianghong
Copy link
Author

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

Ok, I will rebase this PR.

@guxianghong guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch from 5e4ceae to 5282f2a Compare September 24, 2024 01:46
@guxianghong
Copy link
Author

It seems that rebase this PR can't trigger Semgrep. Try to close and reopen to trigger Semgrep.

@guxianghong guxianghong reopened this Sep 24, 2024
@guxianghong
Copy link
Author

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

I tried several attempts, such as rebase to latest master, close/reopen this PR, push new commit to this PR, all of them didn't work, Semgrep can't be triggered. Do you have any other suggestions? @qiluo-msft

@guxianghong
Copy link
Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@guxianghong
Copy link
Author

/azp run Semgrep

Copy link

Commenter does not have sufficient privileges for PR 3011 in repo sonic-net/sonic-utilities

@guxianghong
Copy link
Author

guxianghong commented Sep 25, 2024

Could you merge the latest master branch? I think 'Semgrep' will be triggered after merging.

All pipeline checks have passed, Could you please help to approve and merge this PR, Thanks, @qiluo-msft

… PR#1320

Signed-off-by: Xianghong Gu <xgu@centec.com>
… PR#1320

Signed-off-by: Xianghong Gu <xgu@centec.com>
… PR#1320

Signed-off-by: Xianghong Gu <xgu@centec.com>
@guxianghong guxianghong force-pushed the devpr_xgu_2023100302_support_twamp branch from d4621ee to 294d504 Compare September 26, 2024 05:19
@guxianghong
Copy link
Author

Update to the latest master branch again and resolve conflicts in Command-Reference.md.
Please help to approve and merge this PR, Thakns, @qiluo-msft .

@guxianghong
Copy link
Author

/azp run Semgrep

Copy link

Commenter does not have sufficient privileges for PR 3011 in repo sonic-net/sonic-utilities

@guxianghong
Copy link
Author

/azpw run Semgrep

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Semgrep

Copy link

No pipelines are associated with this pull request.

@guxianghong
Copy link
Author

Please help to merge this PR, @qiluo-msft @zhangyanzhao @liat-grozovik @abdosi @oleksandrivantsiv @yxieca @StormLiangMS @prsunny @zhangyanzhao, Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants