[config] Generate sysinfo as needed when override config #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
May 18, 2023
qiluo-msft
reviewed
May 18, 2023
qiluo-msft
reviewed
May 18, 2023
qiluo-msft
approved these changes
May 25, 2023
wen587
added a commit
that referenced
this pull request
May 31, 2023
What I did It is a bug introduced from #2836. Need to generate sysinfo for single asic. How I did it Reuse the mac and platform in existing device runnning config and generate that if missing. How to verify it Unit test
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Jun 8, 2023
) ADO: 17921518 What I did The generated Golden Config will not have knowledge of configs that are produced in run time, such as mac and platform. Generate that info in Override Config if missing. How I did it Reuse the mac and platform in existing device runnning config and generate that if missing. How to verify it Unit test
|
local test and can be clean picked to 202205. |
yxieca
pushed a commit
that referenced
this pull request
Jun 15, 2023
ADO: 17921518 What I did The generated Golden Config will not have knowledge of configs that are produced in run time, such as mac and platform. Generate that info in Override Config if missing. How I did it Reuse the mac and platform in existing device runnning config and generate that if missing. How to verify it Unit test
yxieca
pushed a commit
that referenced
this pull request
Jun 15, 2023
What I did It is a bug introduced from #2836. Need to generate sysinfo for single asic. How I did it Reuse the mac and platform in existing device runnning config and generate that if missing. How to verify it Unit test
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
) ADO: 17921518 What I did The generated Golden Config will not have knowledge of configs that are produced in run time, such as mac and platform. Generate that info in Override Config if missing. How I did it Reuse the mac and platform in existing device runnning config and generate that if missing. How to verify it Unit test
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
What I did It is a bug introduced from sonic-net#2836. Need to generate sysinfo for single asic. How I did it Reuse the mac and platform in existing device runnning config and generate that if missing. How to verify it Unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 17921518
What I did
The generated Golden Config will not have knowledge of configs that are produced in run time, such as mac and platform.
Generate that info in Override Config if missing.
How I did it
Reuse the mac and platform in existing device runnning config and generate that if missing.
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)