[202205]Fixes #12170: Delete subinterface and recreate the subinterface in default-vrf #2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onic-net#2513) * Fixes #12170: Delete subinterface and recreate the subinterface in default-vrf while unbinding subinterface from user defined vrf.
prsunny
approved these changes
Dec 20, 2022
dgsudharsan
added a commit
to dgsudharsan/sonic-buildimage
that referenced
this pull request
Dec 20, 2022
Update sonic-utilities submodule pointer to include the following: * 67cbb15 [202205]Fixes sonic-net#12170: Delete subinterface and recreate the subinterface in default-vrf ([sonic-net#2564](sonic-net/sonic-utilities#2564)) * 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation ([sonic-net#2562](sonic-net/sonic-utilities#2562)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
8 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Dec 26, 2022
Update sonic-utilities submodule pointer to include the following: * f7988b0 [202205] [timer.unit.j2] use wanted-by in timer unit ([sonic-net#2561](sonic-net/sonic-utilities#2561)) * f45dcfb [generate_dump] Optimize the execution time of 'show techsupport' CLI by paraller function execution ([sonic-net#2565](sonic-net/sonic-utilities#2565)) * 67cbb15 [202205]Fixes sonic-net#12170: Delete subinterface and recreate the subinterface in default-vrf ([sonic-net#2564](sonic-net/sonic-utilities#2564)) * 93172c4 [202205] [generate_dump] Optimize the execution time of the 'show techsupport' script to 5-10% by reducing calls to the 'tar append' operation ([sonic-net#2562](sonic-net/sonic-utilities#2562)) Signed-off-by: dprital <drorp@nvidia.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual cherrypick of #2513
Delete subinterface and recreate the subinterface in default-vrf while unbinding subinterface from user defined vrf.
What I did
Fixes #12170 : sonic-net/sonic-buildimage#12170
Whenever subinterfaces are being unbind, RIF should be deleted and recreated.
How I did it
Fix is split into 2 operations to config DB.
First delete existing subinterface which is configured in user-vrf.
Create subinterface with same attributes in default-vrf.
Step 2 above recreates RIF in default-vrf.
How to verify it
Ensure when subinterface is moved from user-vrf to default-vrf using unbind operation, subinterface is created in default-vrf with same subinterface attributes.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)