Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters #2406

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

Signed-off-by: Vadym Hlushko vadymh@nvidia.com

What I did

Add a new warning message for the 'q_shared_multi' counter and not perform the exit with error code (1) because of the new implementation sonic-swss/pull/2432 from now on there is a valid case if there are no multicast counters inside the COUNTERS_DB.

In order for multicast counters to be presented in COUNTERS_DB the appropriate queues should be configured inside the CONFIG_DB (e.g "BUFFER_QUEUE|Ethernet14|7-8")

How I did it

Change the watermarkstat script

How to verify it

Run the sonic-mgmt/tests/iface_namingmode/test_iface_namingmode.py

Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show queue watermark multicast
Object map is empty!

New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# show queue watermark multicast
Object map from the COUNTERS_DB is empty because the multicast queues are not configured in the CONFIG_DB!

…ters in case if they not in COUNTES_DB

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx vadymhlushko-mlnx changed the title [watermarkstat] Add new warning message for the 'q_shared_multi' counters [watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters Sep 29, 2022
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
vadymhlushko-mlnx and others added 2 commits October 4, 2022 12:41
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2022

This pull request fixes 1 alert when merging fc3f352 into 99425a8 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@vadymhlushko-mlnx
Copy link
Contributor Author

@neethajohn, could you please review it?

@neethajohn neethajohn merged commit 6925947 into sonic-net:202205 Oct 10, 2022
dgsudharsan added a commit to dgsudharsan/sonic-buildimage that referenced this pull request Oct 18, 2022
Update sonic-utilities submodule pointer to include the following:
* ab21b58 [202205] check for vxlan mapping before removing vlan (sonic-net#2388) ([sonic-net#2446](sonic-net/sonic-utilities#2446))
* e111ad4 [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (sonic-net#2265) ([sonic-net#2433](sonic-net/sonic-utilities#2433))
* 6925947 [watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters ([sonic-net#2406](sonic-net/sonic-utilities#2406))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Oct 23, 2022
Update sonic-utilities submodule pointer to include the following:
* ab21b58 [202205] check for vxlan mapping before removing vlan (#2388) ([#2446](sonic-net/sonic-utilities#2446))
* e111ad4 [202205][Auto-Techsupport] Fix the coredump_gen_handler Exception when the History table is empty (#2265) ([#2433](sonic-net/sonic-utilities#2433))
* 6925947 [watermarkstat][202205] Add new warning message for the 'q_shared_multi' counters ([#2406](sonic-net/sonic-utilities#2406))

Signed-off-by: dgsudharsan <sudharsand@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants