[warm/fast-reboot] Fix kexec portion to support platforms based on De… #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sujinmkang : qiluo requested in PR 1966 that this new PR be created to facilitate delivery to the 202012 branch. Thanks, |
|
@dflynn-Nokia Do we still need this PR to be merged? Can you please rebase this PR? |
|
@sujinmkang Yes, I would like this merged to 202012. I will rebase. |
…vice Tree The warm-reboot and fast-reboot commands currently expect a platform that uses GRUB. Information about the current kernel boot arguments is extracted from the GRUB config file. This commit adds support for platforms that do not use GRUB but rather use Device Tree to define the current kernel boot arguments. Example platform architectures using Device Tree include armhf and arm64. This commit also includes a minor improvement to a similar change made to the soft-reboot command in PR# 1963
dflynn-Nokia
force-pushed
the
arm-warm-reboot
branch
from
39b9388
to
2494463
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…vice Tree
The warm-reboot and fast-reboot commands currently expect a platform that uses
GRUB. Information about the current kernel boot arguments is extracted from
the GRUB config file. This commit adds support for platforms that do not use
GRUB but rather use Device Tree to define the current kernel boot arguments.
Example platform architectures using Device Tree include armhf and arm64.
This commit also includes a minor improvement to a similar change made to the
soft-reboot command in PR# 1963
What I did
Fix kexec portion of warm-reboot and fast-reboot commands for the armhf and arm64 platforms
How I did it
Add logic to retrieve kernel boot arguments from the Device Tree rather than from the GRUB config for these platforms
How to verify it
Execute the warm-reboot and fast-reboot commands on an armhf or arm64 platform and confirm that kexec reboots the switch as expected
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)