Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reclaiming buffer][202012] Database migrator for reclaiming buffer #1898

Merged
merged 9 commits into from
Dec 11, 2021

Conversation

stephenxs
Copy link
Collaborator

This is to cherry-pick community PR #1822 to 202012.

What I did

Db migrator support reclaiming reserved buffer for unused ports

As there is no empty slot for database version between 202012 and master (202111), this migration will be done regardless of whether database version is changed. The DB migrator should be idempotent.

Signed-off-by: Stephen Sun stephens@nvidia.com

How I did it

For admin down ports, if the buffer objects configuration aligns with default configuration, set the buffer objects configuration as:

  • Dynamic model: all normal buffer objects are configured on admin down ports. Buffer manager will apply zero profiles on admin down ports.
  • Static model: zero buffer objects are configured on admin down ports.

How to verify it

  1. Unit test.
  2. Manually test.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

stephenxs and others added 8 commits September 26, 2021 08:20
Signed-off-by: Stephen Sun <stephens@nvidia.com>
By doing so, the buffer manager is able to remove it from APPL_DB in warm reboot

Signed-off-by: stephens <stephens@contoso.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: stephens <stephens@contoso.com>
Signed-off-by: stephens <stephens@contoso.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
…profiles removed

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

stephenxs commented Dec 8, 2021

Also cherry-picked a missing logic to test whether it's a double pool module or single pool module.
The corresponding test case is reclaiming-buffer-traditional-single

@liat-grozovik liat-grozovik merged commit 32d18d2 into sonic-net:202012 Dec 11, 2021
@stephenxs stephenxs deleted the reclaim-buffer-202012 branch December 12, 2021 00:57
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
Update submodule sonic-utilities that contains the following commits:

Revert "[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)" (sonic-net#1993)
[soft-reboot] Add support for platforms based on Device Tree (sonic-net#1963)
[Reclaiming buffer][202012] Database migrator for reclaiming buffer (sonic-net#1898)
[202012] [generate_dump] allow to extend dump with plugin scripts (sonic-net#1945)

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants