[config] support for configuring muxcable to manual mode of operation #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
suggested changes
May 27, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
jleveque
previously approved these changes
Jun 1, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tahmed-dev
reviewed
Jun 2, 2021
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 2 alerts when merging 4f943f9 into 25e17de - view on LGTM.com new alerts:
|
tahmed-dev
reviewed
Jun 7, 2021
config/muxcable.py
Outdated
| @@ -74,7 +74,8 @@ def lookup_statedb_and_update_configdb(per_npu_statedb, config_db, port, state_c | |||
|
|
|||
| state = get_value_for_key_in_dict(muxcable_statedb_dict, port, "state", "MUX_CABLE_TABLE") | |||
| if state_cfg_val is not configdb_state: | |||
| config_db.set_entry("MUX_CABLE", port, {"state": state_cfg_val}) | |||
| config_db.set_entry("MUX_CABLE", port, {"state": "active", | |||
There was a problem hiding this comment.
we can fix the lgtm by deleting the ipv4_value and ip64_value.
There was a problem hiding this comment.
also, we are setting the entry to active instead of state_cfg_val.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
tahmed-dev
reviewed
Jun 9, 2021
config/muxcable.py
Outdated
| port_status_dict[port] = 'OK' | ||
| else: | ||
| if str(state_cfg_val) == 'active' and str(state) != 'active': | ||
| config_db.set_entry("MUX_CABLE", port, {"state": state_cfg_val, |
There was a problem hiding this comment.
the config_db.set_entry should be outside the if statement.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
tahmed-dev
approved these changes
Jun 9, 2021
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
…sonic-net#1642) What I did This PR adds support for an option to configure muxcable mode to a manual mode. The manual mode is in addition to auto/active mode. The new output would look like this in case an active flag is passed to the command line admin@sonic:~$ sudo config muxcable mode manual Ethernet0 admin@sonic:~$ sudo config muxcable mode manual all added an option to set muxcable mode to manual mode, in addition to existing auto/active modes. How I did it added the changes in config/muxcable.py and added testcases How to verify it Ran the unit tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 16, 2021
…#1642) What I did This PR adds support for an option to configure muxcable mode to a manual mode. The manual mode is in addition to auto/active mode. The new output would look like this in case an active flag is passed to the command line admin@sonic:~$ sudo config muxcable mode manual Ethernet0 admin@sonic:~$ sudo config muxcable mode manual all added an option to set muxcable mode to manual mode, in addition to existing auto/active modes. How I did it added the changes in config/muxcable.py and added testcases How to verify it Ran the unit tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
…sonic-net#1642) What I did This PR adds support for an option to configure muxcable mode to a manual mode. The manual mode is in addition to auto/active mode. The new output would look like this in case an active flag is passed to the command line admin@sonic:~$ sudo config muxcable mode manual Ethernet0 admin@sonic:~$ sudo config muxcable mode manual all added an option to set muxcable mode to manual mode, in addition to existing auto/active modes. How I did it added the changes in config/muxcable.py and added testcases How to verify it Ran the unit tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
What I did
This PR adds support for an option to configure muxcable mode to a
manualmode. The manual mode is in additionto
auto\activemode.The new output would look like this in case an active flag is passed to the command line
admin@sonic:~$ sudo config muxcable mode manual Ethernet0admin@sonic:~$ sudo config muxcable mode manual alladded an option to set muxcable mode to manual mode, in addition to existing auto/active modes.
How I did it
added the changes in config/muxcable.py and added testcases
How to verify it
Ran the unit tests
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)