Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported #1575

Merged
merged 4 commits into from
Jun 8, 2021

Conversation

stephenxs
Copy link
Collaborator

What I did

Update mellanox buffer migrator with 2km-cable supported

Signed-off-by: Stephen Sun stephens@nvidia.com

How I did it

  1. Introduce database version 1.0.6 which is based on 201911. This version represents the buffer configuration with 2kb-cable supported.
  2. Add mock files for CONFIG_DB for version 1.0.6.
  3. Port some bug fixes from master

How to verify it

Run manually test and unit test.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

stephens added 2 commits April 17, 2021 22:54
- A new db_version 1.0.6 is introduced for the new buffer configuration

Signed-off-by: stephens <stephens@contoso.com>
Signed-off-by: stephens <stephens@contoso.com>
@stephenxs stephenxs marked this pull request as draft April 21, 2021 00:09
Signed-off-by: Stephen Sun <stephens@nvidia.com>
2 lossless PGs will still be configured on uplink ports
But suppose only 1 PG can suffer from congestion at any time,
which means the xoff configured should be half of the real value

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs stephenxs marked this pull request as ready for review May 12, 2021 07:50
@stephenxs stephenxs changed the title [201911][db_migrator][Mellanox] Update mellanox buffer migrator with 2km-cable supported [201911][db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported May 28, 2021
@stephenxs
Copy link
Collaborator Author

Hi @abdosi ,
Can you help merge this PR? We need it for 201911.
Thanks.

@abdosi
Copy link
Contributor

abdosi commented Jun 7, 2021

Hi @abdosi ,
Can you help merge this PR? We need it for 201911.
Thanks.

has this been unit-tested for 201911 and from prev version to one having this changes ?

@stephenxs
Copy link
Collaborator Author

Hi @abdosi ,
Can you help merge this PR? We need it for 201911.
Thanks.

has this been unit-tested for 201911 and from prev version to one having this changes ?

Yes.

@stephenxs
Copy link
Collaborator Author

Hi @abdosi,
Can we have this merged if no further concerns?
Thanks

@abdosi abdosi merged commit 0fa5893 into sonic-net:201911 Jun 8, 2021
@stephenxs stephenxs deleted the 2kb-cable-201911 branch June 9, 2021 00:20
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
da3bbef (HEAD -> 201911)
    [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663)
    0fa5893 (origin/201911)
    [201911][db_migrator][Mellanox] Update Mellanox buffer migrator with
    2km-cable supported (sonic-net#1575)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants