[config] Add checking of speed to "config interface speed" command #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checking whether the desired speed is one of standard Ethernet speed to reject setting unsupportable port speeds. Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com> Signed-off-by: Maksym Belei <Maksym_Belei@jabil.com>
|
retest this please |
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
|
retest this please |
This was referenced Feb 2, 2021
|
@maksymbelei95 - are you going to promote this PR ? |
|
@dprital Could you please review it or assign reviewers |
pshulik
approved these changes
Nov 12, 2021
|
@dprital Could you please review it or assign reviewers |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
[201911] Fixes for NAT lgtm alerts (sonic-net#1391) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to reject setting unsupportable port speeds.
Signed-off-by: d-dashkov Dmytro_Dashkov@Jabil.com
Signed-off-by: Maksym Belei Maksym_Belei@jabil.com
- What I did
Resolves sonic-net/sonic-buildimage#6424
Checking of speed parameter has added to disallow changing of port speed to non-standard values, which are not supported by the system.
- How I did it
Resolves sonic-net/sonic-buildimage#6424
List of standard port speeds has added. The passed speed parameter is being checked by the system. If the speed parameter value is not in port speed list, the system will return error to the CLI output.
- How to verify it
sudo config interface speed Ethernet8 12345678901The system will return the next error:
Error: Invalid value for "<interface_speed>": 12345678901 is not in the valid range of 1000 to 400000.sudo config interface speed Ethernet8 123456The system will return the next error:
Error: The speed 123456 is not allowed. Allowed values: [1000, 2500, 5000, 10000, 25000, 40000, 50000, 100000, 200000, 400000]sudo config interface speed Ethernet8 10000The system will allow the speed. Command
show int statuswill display 10G speed for the interface.- Previous command output (if the output of a command-line utility has changed)
Command
config interface speedwas allowing any speed value, even wrong.- New command output (if the output of a command-line utility has changed)
New behavior is described above.