Add all parameter to show/clear queue watermark command
#1149
Conversation
Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
|
@akokhan, please review |
|
for all new feature, unit tests are required. |
|
Unit tests for this feature were added. |
|
@neethajohn @lguohan, please review |
bratashX
force-pushed
the
improve_show_queue_watermark
branch
from
09c40a8
to
9b34f77
Compare
Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
bratashX
force-pushed
the
improve_show_queue_watermark
branch
2 times, most recently
from
23edbd3
to
20ee6b3
Compare
|
@neethajohn @lguohan, please review and merge |
|
@bratashX , Is there a PR in swss to handle the clear request for 'Q_SHARED_ALL'.? Otherwise the clear command will result in |
@neethajohn Thanks, related PR in sonic-swss: sonic-net/sonic-swss#1653 |
bratashX
changed the title
all parameter to show queue watermark commandall parameter to show/clear queue watermark command
|
@lguohan @neethajohn could you please review and merge |
|
@neethajohn @lguohan could you please merge? Thanks |
What I did Add handling the clear request for 'Q_SHARED_ALL' Why I did it In sonic-net/sonic-utilities#1149 added the following new commands sonic-clear queue persistent-watermark all sonic-clear queue watermark all Without these changes, commands will result in https://github.com/Azure/sonic-swss/blob/master/orchagent/watermarkorch.cpp#L221 Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
|
@neethajohn thanks for merge sonic-net/sonic-swss#1653 |
What I did Add handling the clear request for 'Q_SHARED_ALL' Why I did it In sonic-net/sonic-utilities#1149 added the following new commands sonic-clear queue persistent-watermark all sonic-clear queue watermark all Without these changes, commands will result in https://github.com/Azure/sonic-swss/blob/master/orchagent/watermarkorch.cpp#L221 Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
Signed-off-by: Petro Bratash petrox.bratash@intel.com
Depends on sonic-net/sonic-swss#1653
- What I did
Add new commands :
show queue persistent-watermark allshow queue watermark allsonic-clear queue watermark allsonic-clear queue persistent-watermark all- How I did it
Add q_shared_all type to watermarkstat file
- How to verify it
Execute:
show queue persistent-watermark allshow queue watermark allsonic-clear queue watermark allsonic-clear queue persistent-watermark all- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)