[filter-fdb] Fix Filter FDB With IPv6 Present in Config DB #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter fdb was wiping out IPv4 entries when both IPv4 and IPv6 are associated with VLan interface. The reason is IPv6 network was overwriting IPv4 network. This pr add support to filter both IPv4 and IPv6 addresses signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
lguohan
previously approved these changes
Aug 20, 2020
pavel-shirshov
approved these changes
Aug 24, 2020
tahmed-dev
added a commit
to tahmed-dev/sonic-utilities
that referenced
this pull request
Sep 1, 2020
…#1059) Filter fdb was wiping out IPv4 entries when both IPv4 and IPv6 are associated with VLan interface. The reason is IPv6 network was overwriting IPv4 network. This pr add support to filter both IPv4 and IPv6 addresses signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Sep 3, 2020
* [filter-fdb] Call Filter FDB Main From Within Test Code (#1051) Code coverage requires that python code be run with the same process. Current test code was invoking filter fdb via shell which launches new process and so coverage is not available. This PR calls the main method from within test code. signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com> * [filter-fdb] Fix Filter FDB With IPv6 Present in Config DB (#1059) Filter fdb was wiping out IPv4 entries when both IPv4 and IPv6 are associated with VLan interface. The reason is IPv6 network was overwriting IPv4 network. This pr add support to filter both IPv4 and IPv6 addresses signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
Filter fdb was wiping out IPv4 entries when both IPv4 and IPv6 are associated with VLan interface. The reason is IPv6 network was overwriting IPv4 network. This pr add support to filter both IPv4 and IPv6 addresses signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
3 tasks
CharlieChenEC
pushed a commit
to CharlieChenEC/sonic-utilities
that referenced
this pull request
May 14, 2021
…ll be empty during fast-reboot process
In PR: sonic-net#890
> It adds an mechansim to filter out some entries to reduce the size of fdb.json.
But it has a code defect which causes all fdb entries will be filtered out in some cases.
Merge PR: sonic-net#1059 to fix the above issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter FDB was wiping out IPv4 entries when both IPv4 and IPv6
are associated with VLan interface. The reason is IPv6 network
was overwriting IPv4 network. This pr add support to filter
both IPv4 and IPv6 addresses
Fixes: sonic-net/sonic-buildimage#5216
Closes: sonic-net/sonic-buildimage#5216
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- What I did
Added support for IPv6
- How I did it
New code that addresses both IPv4 and IPv6 networks
- How to verify it
Unit test cases updated to have IPv6 along IPv4 addresses
- Previous command output (if the output of a command-line utility has changed)
N/A
- New command output (if the output of a command-line utility has changed)
N/A