-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[show_sflow_test.py]: Fix show sflow display and Sflow Tests. #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: -- Display ipv4 address with left adjust of 25 width and with space before UDP. -- IPv6 address will be displayed as is. -- Add test data to appl_db.json and config_db.json -- add test file show_sflow_test.py Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
lguohan
reviewed
Aug 14, 2020
lguohan
reviewed
Aug 14, 2020
lguohan
reviewed
Aug 14, 2020
lguohan
reviewed
Aug 14, 2020
lguohan
reviewed
Aug 14, 2020
lguohan
reviewed
Aug 14, 2020
lguohan
reviewed
Aug 14, 2020
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
lguohan
reviewed
Aug 14, 2020
Changes -- use pass_db decorator for sflow_interface. -- since sflow needs ctx, create use Db() in function. -- change the test code accordingly. Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
retest this please |
lguohan
approved these changes
Aug 15, 2020
praveen-li
changed the title
[show_sflow_test.py]: Fix show sflow display.
[show_sflow_test.py]: Fix show sflow display and Sflow Tests.
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
-- Display ipv4 address with left adjust of 25 width and with space before UDP.
-- IPv6 address will be displayed as is.
-- Add test data to appl_db.json and config_db.json
-- add test file show_sflow_test.py
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
- What I did
Changes:
-- Display ipv4 address with left adjust of 25 width and with space before UDP.
-- IPv6 address will be displayed as is.
-- Add test data to appl_db.json and config_db.json
-- add test file show_sflow_test.py
- How I did it
Display ipv4 address with left adjust of 25 width and with space before UDP.
- How to verify it
-- Add test data to appl_db.json and config_db.json
-- add test file show_sflow_test.py
Built with above test:
- Previous command output (if the output of a command-line utility has changed)
Before Fix:
- New command output (if the output of a command-line utility has changed)
After Fix: