Skip to content

Commit

Permalink
[portstat CLI] don't print reminder if use json format (#2670)
Browse files Browse the repository at this point in the history
* no print if use json format
* add print for chassis
  • Loading branch information
wenyiz2021 authored Feb 13, 2023
1 parent ee6d213 commit 2a6a06c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions scripts/portstat
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ from collections import OrderedDict, namedtuple
from natsort import natsorted
from tabulate import tabulate
from sonic_py_common import multi_asic
from sonic_py_common import device_info

# mock the redis for unit test purposes #
try:
Expand Down Expand Up @@ -337,8 +338,8 @@ class Portstat(object):
print(table_as_json(table, header))
else:
print(tabulate(table, header, tablefmt='simple', stralign='right'))
if multi_asic.is_multi_asic():
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")
if multi_asic.is_multi_asic() or device_info.is_chassis():
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")

def cnstat_intf_diff_print(self, cnstat_new_dict, cnstat_old_dict, intf_list):
"""
Expand Down Expand Up @@ -555,8 +556,8 @@ class Portstat(object):
print(table_as_json(table, header))
else:
print(tabulate(table, header, tablefmt='simple', stralign='right'))
if multi_asic.is_multi_asic():
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")
if multi_asic.is_multi_asic() or device_info.is_chassis():
print("\nReminder: Please execute 'show interface counters -d all' to include internal links\n")

def main():
parser = argparse.ArgumentParser(description='Display the ports state and counters',
Expand Down

0 comments on commit 2a6a06c

Please sign in to comment.