[EVPN]Fixing race condition when EVPN NVO add arrives late #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marian-pritsak
approved these changes
May 1, 2023
dgsudharsan
changed the title
|
@srj102 pls help review the change on behalf of BRCM |
|
@qiluo-msft can you help merge this for both master and 202211? |
@moshemos , we are waiting for signoff from @srj102 before merge. |
srj102
approved these changes
May 4, 2023
dgsudharsan
added a commit
to dgsudharsan/sonic-swss
that referenced
this pull request
May 10, 2023
…ic-net#2756)" This reverts commit 750e064.
prsunny
pushed a commit
that referenced
this pull request
May 11, 2023
…)" (#2773) This reverts commit 750e064. Reverts the PR #2756 The fix added breaks the previously added workaround #2626. Hence requesting to revert the fix. Once we find a proper solution for sonic-net/sonic-buildimage#12361 we need to reintegrate this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sonic-net/sonic-buildimage#14949
What I did
Sometime during config reload, EVPN NVO table arrives later than remote VNI table entries. In such scenarios, remote vni entries are ignored and this leads to traffic loss. Added fix to retry instead of ignoring.
Why I did it
To fix race condition as stated in the description
How I verified it
Added UT to verify.
Details if related