MCLAG sync FDB MAC from STATE_DB #1259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 4 alerts when merging 9b54c5c into 3c8289b - view on LGTM.com fixed alerts:
|
|
This pull request fixes 4 alerts when merging 18b50c1 into 727a518 - view on LGTM.com fixed alerts:
|
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
In order to organize code better, reduce the size of large files and help granularize unit test coverage reports, break out the following groups from show/main.py into their own files:
- acl
- dropcounters
- gearbox
- kdump
- nat
- platform
- processes
- sflow
- vnet
- vxlan
- warm_restart
Also remove the following check from utilities_common/cli.py:run_command() and fix all tests which relied upon it:
```
if os.getenv("UTILITIES_UNIT_TESTING") == "1":
return
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Previous implement: Mclagsyncd read MACs from ASIC_DB every 1 minute, and notify the MAC changes to ICCPd. FDB entries learned from MC-LAG enabled port-channel will be synced up with peer.
Currently implement: When fdborch is notified that FDB MAC is changed, it will store the changes to STATE_DB. Mclagsyncd is the consumer of the table FDB_TABLE in STATE_DB, and it will notify the MAC changes to ICCPd. FDB entries learned from MC-LAG enabled port-channel will be synced up with peer.
Why I did it
Mclagsyncd reading MAC periodically every minute consumes system CPU.
How I verified it
Complie and test it on nephos lab
Details if related
This PR must work with the following PR.
Layer 2 Forwarding Enhancements #885