Added batched APIs in ProducerStateTable. #588
Conversation
common/producerstatetable.h
Outdated
| @@ -36,6 +36,17 @@ class ProducerStateTable : public TableBase, public TableName_KeySet | |||
| %} | |||
| #endif | |||
|
|
|||
| // Batched version of set() and del(), for Google usage only. | |||
| // The batched methods are not virtual. They don't include (or use) op and | |||
| // prefix. They are written for specific use case only. | |||
There was a problem hiding this comment.
If you want to add new feature in this repo, it must be implemented for all use cases. This one need cover op and prefix if technically possible. #Closed
There was a problem hiding this comment.
Oops. I need to remove that comment.
In the existing set() and del() API, those arguments are not used. The functions have the arguments but the implementation doesn't use them at all. That's why we remove those arguments in the batched version.
Please comment on how the batched version API should look like. We can add those arguments and not use them in implementation like the existing APIs.
There was a problem hiding this comment.
I deleted the Google specific comments. PTAL.
|
Could you merge latest master? The build issue should be fixed. In reply to: 1089413051 |
mint570
force-pushed
the
batched_api
branch
2 times, most recently
from
28989b6
to
3930394
Compare
Change-Id: Iaca58772659f5e639513b2a49c0cd639b4ba3c1b
Need to make some change for #568. |
Change-Id: Ia50f92bb42abb8f7fd94390bcfb7cb4e3ca8b07d
|
@qiluo-msft |
|
@qiluo-msft |
|
@qiluo-msft |
swss-common: Added batched APIs in ProducerStateTable. HLD: sonic-net/SONiC#959
swss-common: Added batched APIs in ProducerStateTable.
HLD: sonic-net/SONiC#959
Signed-off-by: Runming Wu runmingwu@gmail.com