Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4Runtime : Status Code additions #545

Merged
merged 8 commits into from
Nov 19, 2021
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/json.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -5394,7 +5394,7 @@ class basic_json
{
assert(lhs.m_value.array != nullptr);
assert(rhs.m_value.array != nullptr);
return *lhs.m_value.array < *rhs.m_value.array;
return (*lhs.m_value.array) < *rhs.m_value.array;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix from upstream: nlohmann/json#590

}
case value_t::object:
{
Expand Down
1 change: 1 addition & 0 deletions common/producerstatetable.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#pragma once

#include <memory>
#include <vector>
Copy link
Contributor

@bocon13 bocon13 Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing import. std::vector is used below.

#include "table.h"
#include "redispipeline.h"

Expand Down
76 changes: 76 additions & 0 deletions common/status_code_util.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
#pragma once

#include <map>
#include <string>

namespace swss
{

enum class StatusCode
{
SWSS_RC_SUCCESS,
SWSS_RC_INVALID_PARAM,
SWSS_RC_DEADLINE_EXCEEDED,
SWSS_RC_UNAVAIL,
SWSS_RC_NOT_FOUND,
SWSS_RC_NO_MEMORY,
SWSS_RC_EXISTS,
SWSS_RC_PERMISSION_DENIED,
SWSS_RC_FULL,
SWSS_RC_IN_USE,
SWSS_RC_INTERNAL,
SWSS_RC_UNIMPLEMENTED,
SWSS_RC_UNKNOWN,
};

static const std::map<StatusCode, std::string> statusCodeMapping = {
{StatusCode::SWSS_RC_SUCCESS, "SWSS_RC_SUCCESS"},
{StatusCode::SWSS_RC_INVALID_PARAM, "SWSS_RC_INVALID_PARAM"},
{StatusCode::SWSS_RC_DEADLINE_EXCEEDED, "SWSS_RC_DEADLINE_EXCEEDED"},
{StatusCode::SWSS_RC_UNAVAIL, "SWSS_RC_UNAVAIL"},
{StatusCode::SWSS_RC_NOT_FOUND, "SWSS_RC_NOT_FOUND"},
{StatusCode::SWSS_RC_NO_MEMORY, "SWSS_RC_NO_MEMORY"},
{StatusCode::SWSS_RC_EXISTS, "SWSS_RC_EXISTS"},
{StatusCode::SWSS_RC_PERMISSION_DENIED, "SWSS_RC_PERMISSION_DENIED"},
{StatusCode::SWSS_RC_FULL, "SWSS_RC_FULL"},
{StatusCode::SWSS_RC_IN_USE, "SWSS_RC_IN_USE"},
{StatusCode::SWSS_RC_INTERNAL, "SWSS_RC_INTERNAL"},
{StatusCode::SWSS_RC_UNIMPLEMENTED, "SWSS_RC_UNIMPLEMENTED"},
{StatusCode::SWSS_RC_UNKNOWN, "SWSS_RC_UNKNOWN"},
};

static const std::map<std::string, StatusCode> StatusCodeLookup = {
{"SWSS_RC_SUCCESS", StatusCode::SWSS_RC_SUCCESS},
{"SWSS_RC_INVALID_PARAM", StatusCode::SWSS_RC_INVALID_PARAM},
{"SWSS_RC_DEADLINE_EXCEEDED", StatusCode::SWSS_RC_DEADLINE_EXCEEDED},
{"SWSS_RC_UNAVAIL", StatusCode::SWSS_RC_UNAVAIL},
{"SWSS_RC_NOT_FOUND", StatusCode::SWSS_RC_NOT_FOUND},
{"SWSS_RC_NO_MEMORY", StatusCode::SWSS_RC_NO_MEMORY},
{"SWSS_RC_EXISTS", StatusCode::SWSS_RC_EXISTS},
{"SWSS_RC_PERMISSION_DENIED", StatusCode::SWSS_RC_PERMISSION_DENIED},
{"SWSS_RC_FULL", StatusCode::SWSS_RC_FULL},
{"SWSS_RC_IN_USE", StatusCode::SWSS_RC_IN_USE},
{"SWSS_RC_INTERNAL", StatusCode::SWSS_RC_INTERNAL},
{"SWSS_RC_UNIMPLEMENTED", StatusCode::SWSS_RC_UNIMPLEMENTED},
{"SWSS_RC_UNKNOWN", StatusCode::SWSS_RC_UNKNOWN},
};

static inline std::string statusCodeToStr(const StatusCode &status)
{
if (statusCodeMapping.find(status) == statusCodeMapping.end())
{
return "SWSS_RC_UNKNOWN";
}
return statusCodeMapping.at(status);
}

static inline StatusCode strToStatusCode(const std::string &status)
{
if (StatusCodeLookup.find(status) == StatusCodeLookup.end())
{
return StatusCode::SWSS_RC_UNKNOWN;
}
return StatusCodeLookup.at(status);
}

} // namespace swss
2 changes: 2 additions & 0 deletions pyext/swsscommon.i
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "warm_restart.h"
#include "logger.h"
#include "configdb.h"
#include "status_code_util.h"
%}

%include <std_string.i>
Expand Down Expand Up @@ -203,3 +204,4 @@ T castSelectableObj(swss::Selectable *temp)
%include "warm_restart.h"
%include "dbinterface.h"
%include "logger.h"
%include "status_code_util.h"
1 change: 1 addition & 0 deletions tests/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ tests_SOURCES = redis_ut.cpp \
stringutility_ut.cpp \
redisutility_ut.cpp \
boolean_ut.cpp \
status_code_util_test.cpp \
main.cpp

tests_CFLAGS = $(DBGFLAGS) $(AM_CFLAGS) $(CFLAGS_COMMON) $(CFLAGS_GTEST) $(LIBNL_CFLAGS)
Expand Down
21 changes: 21 additions & 0 deletions tests/status_code_util_test.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
#include "common/status_code_util.h"

#include <gtest/gtest.h>

namespace
{

using swss::StatusCode;

TEST(StatusCodeUtilTest, StatusCodeUtilTest)
{
for (int i = static_cast<int>(StatusCode::SWSS_RC_SUCCESS); i <= static_cast<int>(StatusCode::SWSS_RC_UNKNOWN); ++i)
{
StatusCode original = static_cast<StatusCode>(i);
StatusCode final = swss::strToStatusCode(statusCodeToStr(original));
EXPECT_EQ(original, final);
}
EXPECT_EQ(StatusCode::SWSS_RC_UNKNOWN, swss::strToStatusCode("invalid"));
}

} // namespace