-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P4Runtime : Status Code additions #545
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
81b9354
Add batch ops and StatusCode for PINS / P4Runtime
0596f17
Removing Batch OPs pending further review
d097326
Remove Redis commands
bocon13 e5b57ff
Add status code to pyext
bocon13 d9b41b1
Fix style
bocon13 7a8987e
Revert dbconnector change
bocon13 4e4d34c
Address reviewer comments
bocon13 fa9a1fc
Merge remote-tracking branch 'upstream/master' into pr2-batch-ops
donNewtonAlpha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
#pragma once | ||
|
||
#include <memory> | ||
#include <vector> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is missing import. std::vector is used below. |
||
#include "table.h" | ||
#include "redispipeline.h" | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
#pragma once | ||
|
||
#include <map> | ||
#include <string> | ||
|
||
namespace swss | ||
{ | ||
|
||
enum class StatusCode | ||
{ | ||
SWSS_RC_SUCCESS, | ||
SWSS_RC_INVALID_PARAM, | ||
SWSS_RC_DEADLINE_EXCEEDED, | ||
SWSS_RC_UNAVAIL, | ||
SWSS_RC_NOT_FOUND, | ||
SWSS_RC_NO_MEMORY, | ||
SWSS_RC_EXISTS, | ||
SWSS_RC_PERMISSION_DENIED, | ||
SWSS_RC_FULL, | ||
SWSS_RC_IN_USE, | ||
SWSS_RC_INTERNAL, | ||
SWSS_RC_UNIMPLEMENTED, | ||
SWSS_RC_UNKNOWN, | ||
}; | ||
|
||
static const std::map<StatusCode, std::string> statusCodeMapping = { | ||
{StatusCode::SWSS_RC_SUCCESS, "SWSS_RC_SUCCESS"}, | ||
{StatusCode::SWSS_RC_INVALID_PARAM, "SWSS_RC_INVALID_PARAM"}, | ||
{StatusCode::SWSS_RC_DEADLINE_EXCEEDED, "SWSS_RC_DEADLINE_EXCEEDED"}, | ||
{StatusCode::SWSS_RC_UNAVAIL, "SWSS_RC_UNAVAIL"}, | ||
{StatusCode::SWSS_RC_NOT_FOUND, "SWSS_RC_NOT_FOUND"}, | ||
{StatusCode::SWSS_RC_NO_MEMORY, "SWSS_RC_NO_MEMORY"}, | ||
{StatusCode::SWSS_RC_EXISTS, "SWSS_RC_EXISTS"}, | ||
{StatusCode::SWSS_RC_PERMISSION_DENIED, "SWSS_RC_PERMISSION_DENIED"}, | ||
{StatusCode::SWSS_RC_FULL, "SWSS_RC_FULL"}, | ||
{StatusCode::SWSS_RC_IN_USE, "SWSS_RC_IN_USE"}, | ||
{StatusCode::SWSS_RC_INTERNAL, "SWSS_RC_INTERNAL"}, | ||
{StatusCode::SWSS_RC_UNIMPLEMENTED, "SWSS_RC_UNIMPLEMENTED"}, | ||
{StatusCode::SWSS_RC_UNKNOWN, "SWSS_RC_UNKNOWN"}, | ||
}; | ||
|
||
static const std::map<std::string, StatusCode> StatusCodeLookup = { | ||
{"SWSS_RC_SUCCESS", StatusCode::SWSS_RC_SUCCESS}, | ||
{"SWSS_RC_INVALID_PARAM", StatusCode::SWSS_RC_INVALID_PARAM}, | ||
{"SWSS_RC_DEADLINE_EXCEEDED", StatusCode::SWSS_RC_DEADLINE_EXCEEDED}, | ||
{"SWSS_RC_UNAVAIL", StatusCode::SWSS_RC_UNAVAIL}, | ||
{"SWSS_RC_NOT_FOUND", StatusCode::SWSS_RC_NOT_FOUND}, | ||
{"SWSS_RC_NO_MEMORY", StatusCode::SWSS_RC_NO_MEMORY}, | ||
{"SWSS_RC_EXISTS", StatusCode::SWSS_RC_EXISTS}, | ||
{"SWSS_RC_PERMISSION_DENIED", StatusCode::SWSS_RC_PERMISSION_DENIED}, | ||
{"SWSS_RC_FULL", StatusCode::SWSS_RC_FULL}, | ||
{"SWSS_RC_IN_USE", StatusCode::SWSS_RC_IN_USE}, | ||
{"SWSS_RC_INTERNAL", StatusCode::SWSS_RC_INTERNAL}, | ||
{"SWSS_RC_UNIMPLEMENTED", StatusCode::SWSS_RC_UNIMPLEMENTED}, | ||
{"SWSS_RC_UNKNOWN", StatusCode::SWSS_RC_UNKNOWN}, | ||
}; | ||
|
||
static inline std::string statusCodeToStr(const StatusCode &status) | ||
{ | ||
if (statusCodeMapping.find(status) == statusCodeMapping.end()) | ||
{ | ||
return "SWSS_RC_UNKNOWN"; | ||
} | ||
return statusCodeMapping.at(status); | ||
} | ||
|
||
static inline StatusCode strToStatusCode(const std::string &status) | ||
{ | ||
if (StatusCodeLookup.find(status) == StatusCodeLookup.end()) | ||
{ | ||
return StatusCode::SWSS_RC_UNKNOWN; | ||
} | ||
return StatusCodeLookup.at(status); | ||
} | ||
|
||
} // namespace swss |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
#include "common/status_code_util.h" | ||
|
||
#include <gtest/gtest.h> | ||
|
||
namespace | ||
{ | ||
|
||
using swss::StatusCode; | ||
|
||
TEST(StatusCodeUtilTest, StatusCodeUtilTest) | ||
{ | ||
for (int i = static_cast<int>(StatusCode::SWSS_RC_SUCCESS); i <= static_cast<int>(StatusCode::SWSS_RC_UNKNOWN); ++i) | ||
{ | ||
StatusCode original = static_cast<StatusCode>(i); | ||
StatusCode final = swss::strToStatusCode(statusCodeToStr(original)); | ||
EXPECT_EQ(original, final); | ||
} | ||
EXPECT_EQ(StatusCode::SWSS_RC_UNKNOWN, swss::strToStatusCode("invalid")); | ||
} | ||
|
||
} // namespace |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fix from upstream: nlohmann/json#590