L2MCD:IGMP Snooping Implementation First Commit #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Mar 2, 2020
| @@ -215,7 +221,10 @@ namespace swss { | |||
|
|
|||
| #define CFG_VNET_RT_TABLE_NAME "VNET_ROUTE" | |||
| #define CFG_VNET_RT_TUNNEL_TABLE_NAME "VNET_ROUTE_TUNNEL" | |||
|
|
|||
| #define CFG_L2MC_TABLE_NAME "CFG_L2MC_TABLE" | |||
There was a problem hiding this comment.
please remove "CFG" prefix from table name and request to follow the existing naming in file
There was a problem hiding this comment.
Sure. Working the resolve the references in dependent module and framework.
| @@ -59,6 +59,12 @@ namespace swss { | |||
| #define APP_STP_PORT_STATE_TABLE_NAME "STP_PORT_STATE_TABLE" | |||
| #define APP_STP_FASTAGEING_FLUSH_TABLE_NAME "STP_FASTAGEING_FLUSH_TABLE" | |||
| #define APP_STP_BPDU_GUARD_TABLE_NAME "STP_BPDU_GUARD_TABLE" | |||
|
|
|||
| /* Multicast related APP_DB Tables */ | |||
| #define APP_IPMC_ROUTE_TABLE_NAME "IPMC_ROUTE_TABLE" | |||
There was a problem hiding this comment.
Please align with the rest of the defines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IGMP Snooping Schema changes