Fix: not to use blocking get_all() after keys() #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a dynamic environment, it is possible that some of the keys may disappear between invoking keys() and get_all().
qiluo-msft
requested review from
SuvarnaMeenakshi and
abdosi
and removed request for
SuvarnaMeenakshi
|
Going ahead, how do we figure out if we have to use blocking call or not for a given Table in DB? |
|
qiluo-msft
added a commit
that referenced
this pull request
May 3, 2022
In a dynamic environment, it is possible that some of the keys may disappear between invoking keys() and get_all(). Prevent unnecessary timeout of blocking get_all().
qiluo-msft
added a commit
that referenced
this pull request
May 5, 2022
Follow up #255. If route change too fast between keys/hgetall, the original implementation will throw exception and lead to ERR in syslog.
qiluo-msft
added a commit
to qiluo-msft/sonic-snmpagent
that referenced
this pull request
May 5, 2022
Follow up sonic-net#255. If route change too fast between keys/hgetall, the original implementation will throw exception and lead to ERR in syslog.
judyjoseph
pushed a commit
that referenced
this pull request
May 8, 2022
In a dynamic environment, it is possible that some of the keys may disappear between invoking keys() and get_all(). Prevent unnecessary timeout of blocking get_all().
judyjoseph
pushed a commit
that referenced
this pull request
May 8, 2022
Follow up #255. If route change too fast between keys/hgetall, the original implementation will throw exception and lead to ERR in syslog.
qiluo-msft
added a commit
that referenced
this pull request
May 10, 2022
Follow up #255. If route change too fast between keys/hgetall, the original implementation will throw exception and lead to ERR in syslog.
abdosi
pushed a commit
that referenced
this pull request
May 17, 2022
In a dynamic environment, it is possible that some of the keys may disappear between invoking keys() and get_all(). Prevent unnecessary timeout of blocking get_all().
pttch
pushed a commit
to pttch/sonic-snmpagent
that referenced
this pull request
May 6, 2024
In a dynamic environment, it is possible that some of the keys may disappear between invoking keys() and get_all(). Prevent unnecessary timeout of blocking get_all(). Add more snmp no blocking fix for sonic-net#255 - How I did it Modify the blocking mode from True to False - How to verify it Use server to send with 1000 requests/second. Keep test for weekend and it do not happen.
pttch
added a commit
to pttch/sonic-snmpagent
that referenced
this pull request
May 7, 2024
In a dynamic environment, it is possible that some of the keys may disappear between invoking keys() and get_all(). Prevent unnecessary timeout of blocking get_all(). Add more snmp no blocking fix for sonic-net#255 - How I did it Modify the blocking mode from True to False - How to verify it Use server to send with 1000 requests/second. Keep test for weekend and it do not happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
In a dynamic environment, it is possible that some of the keys may
disappear between invoking keys() and get_all().
Prevent unnecessary timeout of blocking get_all().
- How I did it
- How to verify it
- Description for the changelog