Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synchronization between SNMP MIBs and counters thread #105

Closed

Conversation

stepanblyschak
Copy link
Contributor

@stepanblyschak stepanblyschak commented Apr 12, 2019

Trying to address sonic-net/sonic-buildimage#2750 by removing snmp.timer systemd unit and adding synchronization between counters and SNMP counter dependent MIBs

Added check_ready() interface to suspend reinit_data/update_data
untill a MIBUpdater child specific contition is met.

Used this approach to suspend counters dependent MIBs
untill counters polling thread is started.

check_ready() might be usefull for transceiver or other MIBs as well
but not scope of this change.

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

- What I did
Add synchronization mechanism to MIBUpdater
Wait for counters to be ready before start polling from COUNTERS DB

- How I did it
Added check_ready() interface

- How to verify it

  • unittest
  • SNMP ansible test on DUT

- Description for the changelog
Add synchronization mechanism to MIBUpdater
Wait for counters to be ready before start polling from COUNTERS DB

Added check_ready() interface to suspend reinit_data/update_data
untill a MIBUpdater child specific contition is met.

Used this approach to suspend counters dependent MIBs
untill counters polling thread is started.

check_ready() might be usefull for transceiver or other MIBs as well
but not scope of this change.

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant