Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for new SAI API sai_query_attribute_capability() #645

Merged
merged 5 commits into from
Jul 22, 2020
Merged

Adding support for new SAI API sai_query_attribute_capability() #645

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
99adb7f
Addind support for new SAI API sai_query_attribute_capability()
gechiang Jul 21, 2020
dc86897
Changes based on review comments for SAI API sai_query_attribute_capa…
gechiang Jul 21, 2020
139cf60
Changes based on review comments for SAI API sai_query_attribute_capa…
gechiang Jul 21, 2020
05f32a2
Changes based on review comments for SAI API sai_query_attribute_capa…
gechiang Jul 21, 2020
6a3150d
Changed to return capability in true/false string instead of number s…
gechiang Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/inc/Recorder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ namespace sairedis
_In_ sai_attr_id_t attr_id,
_Out_ sai_attr_capability_t *capability);

void recordQueryAattributeCapabilityResponse(
void recordQueryAttributeCapabilityResponse(
_In_ sai_status_t status,
_In_ sai_object_type_t objectType,
_In_ sai_attr_id_t attrId,
Expand Down
2 changes: 1 addition & 1 deletion lib/src/Recorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ void Recorder::recordQueryAattributeCapability(
}


void Recorder::recordQueryAattributeCapabilityResponse(
void Recorder::recordQueryAttributeCapabilityResponse(
_In_ sai_status_t status,
_In_ sai_object_type_t objectType,
_In_ sai_attr_id_t attrId,
Expand Down
15 changes: 13 additions & 2 deletions lib/src/RedisRemoteSaiInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ sai_status_t RedisRemoteSaiInterface::queryAttributeCapability(

auto status = waitForQueryAttributeCapabilityResponse(capability);

m_recorder->recordQueryAattributeCapabilityResponse(status, objectType, attrId, capability);
m_recorder->recordQueryAttributeCapabilityResponse(status, objectType, attrId, capability);

return status;
}
Expand Down Expand Up @@ -903,19 +903,30 @@ sai_status_t RedisRemoteSaiInterface::waitForQueryAttributeCapabilityResponse(
create_implemented, set_implemented, get_implemented);

if(create_implemented)
{
gechiang marked this conversation as resolved.
Show resolved Hide resolved
capability->create_implemented = true;
}
else
{
capability->create_implemented = false;

}
if(set_implemented)
{
capability->set_implemented = true;
}
else
{
capability->set_implemented = false;
}

if(get_implemented)
{
capability->get_implemented = true;
}
else
{
capability->get_implemented = false;
}
}

return status;
Expand Down