Error Handling Framework: Syncd Changes to report SAI failures #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Capture the SAI return codes - Send the return codes to OrchAgent through a channel - Provision to enable or disable the notification to OA
This was referenced Oct 18, 2019
sivamukka
changed the title
wangshengjun
reviewed
Dec 6, 2019
| { | ||
| SWSS_LOG_ERROR("attr: %s: %s", fvField(v).c_str(), fvValue(v).c_str()); | ||
| internal_syncd_api_send_response(api, status); |
There was a problem hiding this comment.
the else case is redundant, 'internal_syncd_api_send_response' is called at the beginning of the previous 'else' layer.
|
closing this as obsolete, code shifted to cpp, and we already introduced synchronous mode where OA will get correct error message with status code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling framework is responsible for notifying ASIC/SAI programming failures to the applications.
Changes in syncd includes:
Functional specification PR:
sonic-net/SONiC#391
Dependent PRs:
sonic-net/sonic-swss-common#309
sonic-net/sonic-utilities#709
Related PRs:
sonic-net/sonic-utilities#666
sonic-net/sonic-swss#1100
Signed-off-by: Siva Mukka (siva.mukka@broadcom.com)