Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cisco8000 SAI bulk API feature #1153

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

yenlu-keith
Copy link
Contributor

@yenlu-keith yenlu-keith commented Nov 17, 2022

enable cisco8000 SAI bulk API feature

What is the motivation for this PR?
running ipfwd/test_nhop_count.py with cisco8000 will have an log analyzer's error message from monit as below if testcase configs a very huge amount NHG with more NHG members.

E Aug 10 11:05:43.720848 str2-8102-02 ERR monit[513]: 'routeCheck' status failed (255) – Failure results: {{#12 "Unaccounted_ROUTE_ENTRY_TABLE_entries": [#12 "192.168.87.132/31",#12 "192.168.87.134/31",#12 "192.168.87.136/31",#12 "192.168.87.138/31",#12 "192.168.87.150/31",#12 "192.168.87.154/31",#12 "192.168.87.156/31",#12 "192.168.87.158/31",#12 "192.168.87.160/31",#12 "192.168.87.164/31",#12 "192.168.87.166/31",#12 "192.168.87.184/31",#12

ROOT-CAUSE: ASIC_DB and AAPL_DB are not in-sync on route info on time

loganalyzer got "ERR monit" because route-check.py(sonic-utility)
compares with both DB are un-matched on routing within a certain period of time.

cisco@mth64-m5-2:~$
sonic-db-cli ASIC_DB keys * | grep -n 192.183.96.128
ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:
{"dest":"192.183.96.128/25","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000042"}

sonic-db-cli APPL_DB keys * | grep -n 192.183.96.128
ROUTE_TABLE:192.183.96.128/25
nothing...

How did you do it?
enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.

How did you verify/test it?
PASS ipfwd/test_nhop_count.py with configing a very huge amount NHG(ex: 32K) with more NHG members(ex: each NHG with 10).

@kevinskwang
Copy link

Could you add some more description? @yenlu-keith

What is the motivation for this PR?
How did you do it?
How did you verify/test it?

@yenlu-keith
Copy link
Contributor Author

Could you add some more description? @yenlu-keith

What is the motivation for this PR? How did you do it? How did you verify/test it?

sure. updated as above inline.

@kevinskwang
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 47503f1 into sonic-net:master Dec 2, 2022
@prsunny
Copy link
Contributor

prsunny commented Dec 2, 2022

Can you check if its supported on 202012 w.r.t SAI headers?

@yenlu-keith
Copy link
Contributor Author

Can you check if its supported on 202012 w.r.t SAI headers?

we verified based on 202012 branch with cisco 8000 SAI/SDK.

sonic will call diff SAI paths as shown below when applying "-l"
const sai_next_hop_group_api_t next_hop_group_api = {
create_next_hop_group,
remove_next_hop_group,
set_next_hop_group_attribute,
get_next_hop_group_attribute,
create_next_hop_group_member, => old
remove_next_hop_group_member, => old
set_next_hop_group_member_attribute,
get_next_hop_group_member_attribute,
create_next_hop_group_members, => new
remove_next_hop_group_members, => new

is this what u ask?

yenlu-keith added a commit to yenlu-keith/sonic-sairedis that referenced this pull request Dec 2, 2022
*[Cisco] enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.
yenlu-keith added a commit to yenlu-keith/sonic-sairedis that referenced this pull request Dec 2, 2022
*[Cisco] enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.
kevinskwang pushed a commit that referenced this pull request Dec 6, 2022
*[Cisco] enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.
yxieca pushed a commit that referenced this pull request Dec 7, 2022
*[Cisco] enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.
@yenlu-keith yenlu-keith deleted the local-master-saibulk-cisco branch December 9, 2022 18:58
kevinskwang pushed a commit that referenced this pull request Jan 6, 2023
*[Cisco] enable SAI bulk API config from syncd to pass a set of Rid and review code-flow performance on cisco SAI/SDK layer. until route-check.py(sonic-utility) will not dump the associated ERR message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants