Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No sai api version check if vendor sai does not support #1063

Merged
merged 1 commit into from
Jun 11, 2022
Merged

No sai api version check if vendor sai does not support #1063

merged 1 commit into from
Jun 11, 2022

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Jun 11, 2022 •
edited
Loading

Fix #1062

Test log:

dpkg --list | grep libsaibcm
ii  libsaibcm                              7.1.0.0-1                               amd64        Switch Abstraction Interface sdk based on Broadcom SAI
ii  libsaibcm-dev                          7.1.0.0-1                               amd64        development files for Switch Abstraction Interface sdk

checking for main in -lsai... yes
configure: libsai found
checking for swig3.0... /usr/bin/swig3.0
checking whether CXX supports -Wcast-align=strict... yes
checking whether CXX supports -Wno-cast-function-type... yes
checking for sai_query_api_version... no

Signed-off-by: Guohan Lu lguohan@gmail.com

@lguohan
No sai api version check if vendor sai does not support
d113b4d 
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan requested a review from kcudnik June 11, 2022 08:59
@lguohan lguohan merged commit cdf9427 into sonic-net:master Jun 11, 2022
@lguohan lguohan deleted the apiv branch June 11, 2022 17:30
@kcudnik
Copy link
Collaborator

kcudnik commented Jun 13, 2022

good change

pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@lguohan
No sai api version check if vendor sai does not support (sonic-net#1063)
8126c75 
Fix sonic-net#1062

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcudnik kcudnik Awaiting requested review from kcudnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syncd build failure on broadcom.
2 participants
@lguohan @kcudnik