Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911] Migrate from sonic-daemon-base package to sonic-py-common package #83

Merged
merged 1 commit into from
Aug 13, 2020
Merged

[201911] Migrate from sonic-daemon-base package to sonic-py-common package #83

merged 1 commit into from
Aug 13, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Aug 8, 2020

As part of consolidating all common Python-based functionality into the new sonic-py-common package, this pull request migrates from importing the sonic-daemon-base package to importing the sonic-py-common package. This is the next step toward resolving sonic-net/sonic-buildimage#4999.

  • Also reorganize imports for consistency

As part of consolidating all common Python-based functionality into the new sonic-py-common package, this pull request migrates from importing the sonic-daemon-base package to importing the sonic-py-common package. This is the next step toward resolving sonic-net/sonic-buildimage#4999.

- Also reorganize imports for consistency
@jleveque jleveque self-assigned this Aug 8, 2020
@jleveque jleveque changed the title Migrate from sonic-daemon-base package to sonic-py-common package [201911] Migrate from sonic-daemon-base package to sonic-py-common package Aug 8, 2020
@lgtm-com
Copy link

lgtm-com bot commented Aug 8, 2020

This pull request fixes 4 alerts when merging 871a922 into e2160e5 - view on LGTM.com

fixed alerts:

  • 4 for Unused import

@jleveque jleveque marked this pull request as ready for review August 12, 2020 01:46
@jleveque jleveque merged commit c65d1d6 into sonic-net:201911 Aug 13, 2020
@jleveque jleveque deleted the use_sonic_py_common_201911 branch August 13, 2020 23:42
@abdosi
Copy link
Contributor

abdosi commented Aug 13, 2020

@jleveque is submodule updated for 201911 ?

@jleveque
Copy link
Contributor Author

jleveque commented Aug 13, 2020

@abdosi: No. I was going to ask you. sonic-utilities will also be merged today and will also need to be updated.

@abdosi
Copy link
Contributor

abdosi commented Aug 14, 2020

@jleveque Done

vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants