[ycable] Curb log messages in active-active by changing verbosity level; fix missing namespaces in delete event handle #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cable type Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
prgeor
previously approved these changes
Aug 8, 2023
vdahiya12
force-pushed
the
update-log-level
branch
from
0a25aa5
to
784b9e2
Compare
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
changed the title
prgeor
approved these changes
Aug 17, 2023
yxieca
pushed a commit
that referenced
this pull request
Aug 17, 2023
…el; fix missing namespaces in delete event handle (#391) * [ycabled][active-active] Correct the behavior when no active-active cable type Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
tshalvi
pushed a commit
to tshalvi/sonic-platform-daemons
that referenced
this pull request
Sep 11, 2023
…el; fix missing namespaces in delete event handle (sonic-net#391) * [ycabled][active-active] Correct the behavior when no active-active cable type Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
|
@vdahiya12 could we have an ADO to support this cherry pick? |
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 21, 2023
…el; fix missing namespaces in delete event handle (#391) * [ycabled][active-active] Correct the behavior when no active-active cable type Signed-off-by: vaibhav dahiya <vdahiya@microsoft.com>
@StormLiangMS please use this 24608402 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR conversts some log_warning and log_error messages which are redundant in images to log_debug messages and the debug messages can be enabled whenever required.
It also fixes a missing namespaces initialization not initialized earlier. if this delete event is executed without this change, ycabled can possibly restart, this change fixes the issue
Description
Motivation and Context
How Has This Been Tested?
UT
Additional Information (Optional)