Fixes for the issues uncovered by sonic-pcied unit tests #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows
dgsudharsan
approved these changes
Jul 18, 2023
|
@assrinivasan can you remove the mocked table from all the tests and instead use the mocked lib of swsscommon? Ex:https://github.com/sonic-net/sonic-platform-daemons/blob/master/sonic-pcied/tests/test_DaemonPcied.py#L285 |
Done in latest commit. |
dgsudharsan
approved these changes
Jul 19, 2023
prgeor
approved these changes
Jul 19, 2023
|
/easycla |
assrinivasan
added a commit
to assrinivasan/sonic-platform-daemons
that referenced
this pull request
Aug 8, 2023
…ic-net#389)" This reverts commit 76baca3.
assrinivasan
added a commit
to assrinivasan/sonic-platform-daemons
that referenced
this pull request
Aug 8, 2023
* Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
prgeor
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
tshalvi
pushed a commit
to tshalvi/sonic-platform-daemons
that referenced
this pull request
Sep 11, 2023
* Revert "Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389)" This reverts commit 76baca3. * Revert "Added PCIe transaction check for all peripherals on the bus (sonic-net#331)" This reverts commit d73808c. * Fixes for the issues uncovered by sonic-pcied unit tests (sonic-net#389) * Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
|
@prgeor could we have ADO to support this cherry pick? |
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 21, 2023
* Fixes for the following issues: - Lack of getKeys() impl in mock swsscommon table class in sonic-pcied - Fixed a 'set' bug in pcied that was uncovered by new code flows * Removed mocked table instances per prgeor review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes for the following issues:
Motivation and Context
This PR fixes issues in pcied as well as mock implementations for unit tests that were uncovered by new code flows.
How Has This Been Tested?
Recreated the new code flow with the changes and ensured that all the tests passed without exceptions