-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ycabled][active-active] no initialize Async Client, when no active-active cable type; fix names for all ycabled threads #373
Conversation
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vdahiya12 please fix the code coverage
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add ADO# and proper branch labels.
Also please wait for approval from Prince G. before merging.
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
4dc7839
to
16a78cc
Compare
…ctive cable type; fix names for all ycabled threads (#373) This PR intends to not start sonic-ycabled's Asynchronous client, when there is no active-active cable type. The Problem that we encounter is ycabled expects all threads to be working/running state all the time. Since there are no active-active cable_type Async client thread exits gracefully, but by design this needs to be working if added to monitor loop thread. So this PR fixes this problem by runnig the Async Client only if configuration is active-active for atleast a cable. This PR also has all the infrastructure changes UT for all Classes having infinite loops in ycabled, thus helping in picking up cases if changes break the code. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@yxieca please wait before merging to this repo |
@StormLiangMS please cherry pick to 202305 |
…ctive cable type; fix names for all ycabled threads (#373) This PR intends to not start sonic-ycabled's Asynchronous client, when there is no active-active cable type. The Problem that we encounter is ycabled expects all threads to be working/running state all the time. Since there are no active-active cable_type Async client thread exits gracefully, but by design this needs to be working if added to monitor loop thread. So this PR fixes this problem by runnig the Async Client only if configuration is active-active for atleast a cable. This PR also has all the infrastructure changes UT for all Classes having infinite loops in ycabled, thus helping in picking up cases if changes break the code. Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This PR intends to not start sonic-ycabled's Asynchronous client, when there is no active-active cable type.
The Problem that we encounter is ycabled expects all threads to be working/running state all the time.
Since there are no
active-active
cable_type Async client thread exits gracefully,but by design this needs to be working if added to monitor loop thread. So this PR fixes this problem by runnig the Async Client only if configuration is
active-active
for atleast a cable.This PR also has all the infrastructure changes UT for all Classes having infinite loops in ycabled, thus helping in picking up cases if changes break the code.
MSFT ADO: 24121234
Description
Motivation and Context
How Has This Been Tested?
Running on DUT and UT
Additional Information (Optional)