[PSU power threshold] Fix logic error: compare the system power with the PSU's power threshold #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the system power instead of PSU power against a single PSU's threshold Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
enhance-psu-threshold-check
branch
from
34c9d4a
to
1dc878c
Compare
stephenxs
changed the title
stephenxs
changed the title
11 tasks
keboliu
approved these changes
Jul 7, 2023
prgeor
approved these changes
Jul 7, 2023
|
@prgeor could you create ADO for this? |
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 14, 2023
…the PSU's power threshold (#367) * Adjust the logic to check PSU power threshold Check the system power instead of PSU power against a single PSU's threshold Signed-off-by: Stephen Sun <stephens@nvidia.com> * Log only once instead of logging per PSU Signed-off-by: Stephen Sun <stephens@nvidia.com> --------- Signed-off-by: Stephen Sun <stephens@nvidia.com>
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 14, 2023
…the PSU's power threshold (#367) * Adjust the logic to check PSU power threshold Check the system power instead of PSU power against a single PSU's threshold Signed-off-by: Stephen Sun <stephens@nvidia.com> * Log only once instead of logging per PSU Signed-off-by: Stephen Sun <stephens@nvidia.com> --------- Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Compare the system power instead of PSU power with the PSU's threshold.
On a system with more than one PSU, the power consumption will not distribute evenly on both PSUs, as a result, it gives a wrong message sometimes.
To fix the error, it should compare system power with the PSU's threshold.
How Has This Been Tested?
Unit test
Manual test
Regression test
Additional Information (Optional)