Chassisd do an explicit stop of the config_manager #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgeor
previously approved these changes
Jan 5, 2023
|
@judyjoseph code coverage |
|
@abdosi : Can you please request for double commit of this into 202205 branch? |
Added tests - code coverage is good now |
prgeor
reviewed
Jan 17, 2023
prgeor
reviewed
Jan 17, 2023
prgeor
previously approved these changes
Jan 17, 2023
prgeor
approved these changes
Jan 17, 2023
|
@judyjoseph can we get this committed to 202205 branch as well? |
yxieca
pushed a commit
that referenced
this pull request
Jan 19, 2023
* Fix to explicit stop the config_manager * Add tests for chassisd run method.
yxieca
added
Included in 202205 Branch
Cherry Pick Conflict_202205
and removed
Included in 202205 Branch
labels
|
This change is reverted from 202205 due to build failure. Please ping me when the build failure fix is in. |
@abdosi : Please check it |
judyjoseph
added a commit
to judyjoseph/sonic-platform-daemons
that referenced
this pull request
Feb 1, 2023
* Fix to explicit stop the config_manager * Add tests for chassisd run method.
Raised PR : #336 |
yxieca
pushed a commit
that referenced
this pull request
Feb 1, 2023
patrickmacarthur
pushed a commit
to patrickmacarthur/sonic-platform-daemons
that referenced
this pull request
Apr 20, 2023
* Fix to explicit stop the config_manager * Add tests for chassisd run method.
patrickmacarthur
pushed a commit
to patrickmacarthur/sonic-platform-daemons
that referenced
this pull request
Jul 12, 2023
* Fix to explicit stop the config_manager * Add tests for chassisd run method.
gechiang
pushed a commit
that referenced
this pull request
Jul 19, 2023
* Chassisd do an explicit stop of the config_manager (#328) * Fix to explicit stop the config_manager * Add tests for chassisd run method. * chassisd: Fix crash on exit on linecard Set the `config_manager` variable to `None` if we are running on a linecard and thus don't need to set up the config manager. During cleanup, the chassid service tries to clean up the `config_manager`, but the `config_manager` variable is only ever initialized if we are on the supervisor. Thus, checking if it is `None` is insufficient because this results in an `UnboundLocalError` that prevents the cleanup from succeeding on a linecard. --------- Co-authored-by: judyjoseph <53951155+judyjoseph@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do an explicit task stop of config_manager task in the chassisd
Motivation and Context
Fixes issue sonic-net/sonic-buildimage#11955
How Has This Been Tested?
Updated the test_chassisd.py as per sonic-net/sonic-mgmt#7150 and made sure it is a consistent PASS
Additional Information (Optional)