-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ycabled] fix exception-handling logic for ycabled #312
[ycabled] fix exception-handling logic for ycabled #312
Conversation
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This pull request introduces 4 alerts when merging bf9881f into aacb772 - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This pull request introduces 4 alerts when merging ebd7d4f into 3d5470d - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This pull request introduces 4 alerts when merging b1b40eb into 3d5470d - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 35a8345 into 3d5470d - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This pull request introduces 4 alerts when merging 8480ff3 into 3d5470d - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
This pull request introduces 4 alerts when merging 57626c8 into 3d5470d - view on LGTM.com new alerts:
|
Cherry-pick conflict
#306
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR is changing how exception handling is handled in python threading.
In python3.7 if child thread gets an exception, there is no way of knowing an exception occured, unless a join is called. The problem is resolved in this PR
Also task classes are structured this way
This allows helping catching the exception thrown by a child thread get caught along with traceback.
Main thread has a while loop, which monitors each thread, if not running will kill the whole process and supervisord will bring back the ycabled up.
Description
Motivation and Context
How Has This Been Tested?
Unit-tests and deploying changes on testbed
Additional Information (Optional)
sonic-mgmt tests which pass with this change
No exceptions observed, ycabled seems healthy with true thread count