[thermalctld] Enable stopping thermal manager #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liat-grozovik
approved these changes
May 9, 2021
jleveque
approved these changes
May 10, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
May 18, 2021
Make thermalctld exit as soon as possible. Depends on sonic-net/sonic-platform-common#187 During config reload flow, supervisord sends SIGTERM to thermalctld. However, if thermalctld cannot exit in 10 seconds, supervisord sends SITKILL to thermalctld. In this case, sub process of thermalctld might still stay in memory as a zombie process. This PR is aimed to fix this.
andywongarista
pushed a commit
to andywongarista/sonic-platform-daemons
that referenced
this pull request
Jun 30, 2021
Make thermalctld exit as soon as possible. Depends on sonic-net/sonic-platform-common#187 During config reload flow, supervisord sends SIGTERM to thermalctld. However, if thermalctld cannot exit in 10 seconds, supervisord sends SITKILL to thermalctld. In this case, sub process of thermalctld might still stay in memory as a zombie process. This PR is aimed to fix this.
vdahiya12
pushed a commit
to vdahiya12/sonic-platform-daemons
that referenced
this pull request
Apr 4, 2022
…t#180) Two new functions have been added to thermal_base.py for setting critical temperature thresholds. Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make thermalctld exit as soon as possible. Depends on sonic-net/sonic-platform-common#187
Motivation and Context
During config reload flow, supervisord sends SIGTERM to thermalctld. However, if thermalctld cannot exit in 10 seconds, supervisord sends SITKILL to thermalctld. In this case, sub process of thermalctld might still stay in memory as a zombe process. This PR is aimed to fix this.
How Has This Been Tested?
Additional Information (Optional)