[CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ready Signed-off-by: Kebo Liu <kebol@nvidia.com>
prgeor
reviewed
Sep 1, 2022
Signed-off-by: Kebo Liu <kebol@nvidia.com>
prgeor
approved these changes
Sep 2, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 4, 2022
Update sonic-platform-common submodule pointer to include the following: * [CMIS] 'get_transceiver_info' should return 'None' when CMIS cable EEPROM is not ready ([sonic-net#305](sonic-net/sonic-platform-common#305)) * uplift code coverage 80% ([sonic-net#307](sonic-net/sonic-platform-common#307)) * [sonic-pcie] Add UT for pcie_common.py ([sonic-net#293](sonic-net/sonic-platform-common#293)) * [CMIS] Catch Exception to avoid CMIS code crash ([sonic-net#299](sonic-net/sonic-platform-common#299)) * [Credo][Ycable] fix incorrect uart statistics ([sonic-net#296](sonic-net/sonic-platform-common#296)) * Add PSU input voltage and input current ([sonic-net#295](sonic-net/sonic-platform-common#295)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 8, 2022
…PROM is not ready (#305) * get_transceiver_info should return None when cmis cable eeprom is not ready Signed-off-by: Kebo Liu <kebol@nvidia.com> * Add more comments to describe the change Signed-off-by: Kebo Liu <kebol@nvidia.com> Signed-off-by: Kebo Liu <kebol@nvidia.com>
yxieca
added
Cherry Pick Conflict_202205
Included in 202205 Branch
and removed
Cherry Pick Conflict_202205
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu kebol@nvidia.com
Description
When the CMIS cable EEPROM is not ready,
get_transceiver_infoshould return None to notify XCVRD that cable EEPROM is not ready instead of returning a dictionary including 'None' values.If any field is 'None', we consider the CMIS cable EEPROM is not fully ready yet.
Motivation and Context
get_transceiver_infoshould return a dictionary including the correct field and values to XCVRD, if EEPROM is not ready should not return a dictionary with incorrect values. The 'None' return value can trigger XCVRD to start the retry EEPROM reading flow.This is also to fix issue sonic-net/sonic-buildimage#11525
How Has This Been Tested?
keep run sfputil reset test case and see no further crash.
Additional Information (Optional)