Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass replace_lane to unblock submodule update #5847

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

wen587
Copy link
Contributor

@wen587 wen587 commented Jun 21, 2022

Description of PR

Summary: Suspect test bug in test_eth_interface.py. Skip for now and request further investigation.
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

isabelmsft
isabelmsft previously approved these changes Jun 21, 2022
expect_op_failure(output)
finally:
delete_tmpfile(duthost, tmpfile)
#def test_replace_lanes(duthost, ensure_dut_readiness):
Copy link
Contributor

@qiluo-msft qiluo-msft Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_replace_lanes

Could you use @pytest.mark.skip(reason="...") and provide a reason?

Currently I could not understand the motivation from your PR description. #Closed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

@wen587 wen587 merged commit 774978f into sonic-net:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants