Make some Ansible scripts support both Python 2 and 3 #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
This pull request introduces 2 alerts and fixes 3 when merging d011ece into bac8b9b - view on LGTM.com new alerts:
fixed alerts:
|
qiluo-msft
reviewed
Aug 6, 2021
qiluo-msft
reviewed
Aug 6, 2021
lolyu
reviewed
Aug 6, 2021
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
This pull request fixes 2 alerts when merging f4db4ee into ea0d0c6 - view on LGTM.com fixed alerts:
|
yxieca
approved these changes
Aug 6, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Make some Ansible scripts support both Python 2 and 3 Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Make some more Ansible scripts and modules compatible with both Python 2 and 3.
This is in preparation for sonic-net/sonic-buildimage#8191
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
Used 2to3 tool for conversion, followed by manual edits for handling both Python 2 and 3, excluding some changes, and making some additional missed changes.
How did you verify/test it?
Tested by running bgp_fact and kvmtest on Bullseye image. bgp_fact appears to fully pass, kvmtest is failing on one test (
platform_tests/test_advanced_reboot.py::test_fast_reboot)Need to test on current master image.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation