-
Notifications
You must be signed in to change notification settings - Fork 714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add check neighbors health for SONiC neighbor devices #3481
Conversation
fdf78d4
to
4e340df
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Ze Gan <ganze718@gmail.com>
4e340df
to
d592c1d
Compare
""" | ||
Shortcut fixture for getting VM host | ||
""" | ||
|
||
vm_base = int(tbinfo['vm_base'][2:]) | ||
neighbor_type = request.config.getoption("--neighbor_type") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to detect the type of neighbor? Then the "--neighbor_type" option would be unnecessary. It would be easier to trigger tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any elegant idea to check the type of neighbor.
In my mind, we can only get the type after we login the device, but the password and username is different between EOS and SONiC, so it requires that we need to know the type before we login the device.
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan ganze718@gmail.com
Description of PR
./run_tests.sh -E -n vms-kvm-t0 -d vlab-01 -c test_nbr_health.py -f vtestbed.csv -i veos_vtb -e "--neighbor_type=sonic"
Summary:
Add test for neighbor health if the neighbor devices are SONiC
Type of change
Approach
What is the motivation for this PR?
To check the neighbor health if the neighbor devices are SONiC
How did you do it?
Add a command argument of pytest to indicate the neighbor device type so that we can choose different flow when we check the neighbor health.
How did you verify/test it?
./run_tests.sh -n vms-kvm-t0 -d vlab-01 -c bgp/test_bgp_fact.py -f vtestbed.csv -i veos_vtb -e "--neighbor_type=sonic"
Any platform specific information?
None
Supported testbed topology if it's a new test case?
None
Documentation